You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Jürgen Gahl (JIRA)" <ji...@apache.org> on 2009/10/29 14:49:59 UTC

[jira] Created: (PLUTO-583) PortalURLParserImpl: unnecessary "?"

PortalURLParserImpl: unnecessary "?"
------------------------------------

                 Key: PLUTO-583
                 URL: https://issues.apache.org/jira/browse/PLUTO-583
             Project: Pluto
          Issue Type: Bug
          Components: portal driver
    Affects Versions: 2.0.0
            Reporter: Jürgen Gahl
            Priority: Trivial


When creating an URL with "public String toString(PortalURL portalURL)" an unnecessary "?" is added if the query is empty (org.apache.pluto.driver.url.impl.PortalURLParserImpl). 
This is the part of the source code where the URL is finally composed:

---
        // Construct the string representing the portal URL.
        // Fix for PLUTO-247 - check if query string contains parameters
        if ( query.length() > 1 ) {
            return buffer.append(query).toString();
        }

        // Construct the string representing the portal URL.
        return buffer.append(query).toString();
---

There was already a fix for this issue (PLUTO-247). May be this reappeared after some refactoring. The statement in the if-block and the one behind the if-block is the same.
The unnecessary "?" caused problems when using the URL as action in a form within a HTTPUnit-Test because the testframework does not look at the final character of the URL and adds an additional "?".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (PLUTO-583) PortalURLParserImpl: unnecessary "?"

Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma resolved PLUTO-583.
-----------------------------

    Fix Version/s: 2.0.2
                   2.1.0
       Resolution: Fixed

Fixed, thanks for reporting.

> PortalURLParserImpl: unnecessary "?"
> ------------------------------------
>
>                 Key: PLUTO-583
>                 URL: https://issues.apache.org/jira/browse/PLUTO-583
>             Project: Pluto
>          Issue Type: Bug
>          Components: portal driver
>    Affects Versions: 2.0.0
>            Reporter: Jürgen Gahl
>            Assignee: Ate Douma
>            Priority: Trivial
>             Fix For: 2.0.2, 2.1.0
>
>
> When creating an URL with "public String toString(PortalURL portalURL)" an unnecessary "?" is added if the query is empty (org.apache.pluto.driver.url.impl.PortalURLParserImpl). 
> This is the part of the source code where the URL is finally composed:
> ---
>         // Construct the string representing the portal URL.
>         // Fix for PLUTO-247 - check if query string contains parameters
>         if ( query.length() > 1 ) {
>             return buffer.append(query).toString();
>         }
>         // Construct the string representing the portal URL.
>         return buffer.append(query).toString();
> ---
> There was already a fix for this issue (PLUTO-247). May be this reappeared after some refactoring. The statement in the if-block and the one behind the if-block is the same.
> The unnecessary "?" caused problems when using the URL as action in a form within a HTTPUnit-Test because the testframework does not look at the final character of the URL and adds an additional "?".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (PLUTO-583) PortalURLParserImpl: unnecessary "?"

Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma reassigned PLUTO-583:
-------------------------------

    Assignee: Ate Douma

> PortalURLParserImpl: unnecessary "?"
> ------------------------------------
>
>                 Key: PLUTO-583
>                 URL: https://issues.apache.org/jira/browse/PLUTO-583
>             Project: Pluto
>          Issue Type: Bug
>          Components: portal driver
>    Affects Versions: 2.0.0
>            Reporter: Jürgen Gahl
>            Assignee: Ate Douma
>            Priority: Trivial
>
> When creating an URL with "public String toString(PortalURL portalURL)" an unnecessary "?" is added if the query is empty (org.apache.pluto.driver.url.impl.PortalURLParserImpl). 
> This is the part of the source code where the URL is finally composed:
> ---
>         // Construct the string representing the portal URL.
>         // Fix for PLUTO-247 - check if query string contains parameters
>         if ( query.length() > 1 ) {
>             return buffer.append(query).toString();
>         }
>         // Construct the string representing the portal URL.
>         return buffer.append(query).toString();
> ---
> There was already a fix for this issue (PLUTO-247). May be this reappeared after some refactoring. The statement in the if-block and the one behind the if-block is the same.
> The unnecessary "?" caused problems when using the URL as action in a form within a HTTPUnit-Test because the testframework does not look at the final character of the URL and adds an additional "?".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.