You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/08 17:44:33 UTC

[GitHub] [skywalking-python] muse-dev[bot] commented on a change in pull request #93: [Fix][Plugin] sw_flask general exceptions handled

muse-dev[bot] commented on a change in pull request #93:
URL: https://github.com/apache/skywalking-python/pull/93#discussion_r538651660



##########
File path: skywalking/trace/carrier.py
##########
@@ -44,18 +44,22 @@ def val(self, val: str):
 
 
 class Carrier(CarrierItem):
-    def __init__(self):
+    def __init__(self, trace_id: str = '', segment_id: str = '', span_id: str = '', service: str = '',
+                 service_instance: str = '', endpoint: str = '', client_address: str = '',
+                 correlation: dict = None):

Review comment:
       *Incompatible variable type:*  correlation is declared to have type `typing.Dict[typing.Any, typing.Any]` but is used as type `None`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org