You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Erick Erickson <er...@gmail.com> on 2016/03/22 02:21:48 UTC
Why does CloudConfigSetService.configName return the collection?
A client pointed this out. For arcane reasons they wanted to get the
configset name given a CoreDescriptor and were trying to use
CloudConfigSetService.configName(). The code for that method is:
public String configName(CoreDescriptor cd) {
return "collection " + cd.getCloudDescriptor().getCollectionName();
}
Does this ring any bells? Should I raise a JIRA? I'm not completely
sure what the right thing to do here is, but it seems odd to return
the collection from this method.
Alan Woodward: This is part of SOLR-4478, do you have any recollection
of why it was done this way?
Erick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Why does CloudConfigSetService.configName return the collection?
Posted by Erick Erickson <er...@gmail.com>.
I'll open a JIRA in a second. My puzzlement was the mis-match between
the method name and the returned value struck me as odd...
Not a big deal, the root question is how to get the configset name
from a core descriptor.
Erick
On Tue, Mar 22, 2016 at 1:17 AM, Alan Woodward <al...@flax.co.uk> wrote:
> The configset name is only used in logging at the moment. I agree that it
> would be useful to get the config that it was loaded from as well as the
> collection it's to be used for, though. I'd say open a JIRA.
>
> Alan Woodward
> www.flax.co.uk
>
>
> On 22 Mar 2016, at 01:21, Erick Erickson wrote:
>
> A client pointed this out. For arcane reasons they wanted to get the
> configset name given a CoreDescriptor and were trying to use
> CloudConfigSetService.configName(). The code for that method is:
>
> public String configName(CoreDescriptor cd) {
> return "collection " + cd.getCloudDescriptor().getCollectionName();
> }
>
>
> Does this ring any bells? Should I raise a JIRA? I'm not completely
> sure what the right thing to do here is, but it seems odd to return
> the collection from this method.
>
> Alan Woodward: This is part of SOLR-4478, do you have any recollection
> of why it was done this way?
>
> Erick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Why does CloudConfigSetService.configName return the collection?
Posted by Alan Woodward <al...@flax.co.uk>.
The configset name is only used in logging at the moment. I agree that it would be useful to get the config that it was loaded from as well as the collection it's to be used for, though. I'd say open a JIRA.
Alan Woodward
www.flax.co.uk
On 22 Mar 2016, at 01:21, Erick Erickson wrote:
> A client pointed this out. For arcane reasons they wanted to get the
> configset name given a CoreDescriptor and were trying to use
> CloudConfigSetService.configName(). The code for that method is:
>
> public String configName(CoreDescriptor cd) {
> return "collection " + cd.getCloudDescriptor().getCollectionName();
> }
>
>
> Does this ring any bells? Should I raise a JIRA? I'm not completely
> sure what the right thing to do here is, but it seems odd to return
> the collection from this method.
>
> Alan Woodward: This is part of SOLR-4478, do you have any recollection
> of why it was done this way?
>
> Erick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>