You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/05/04 23:22:46 UTC
Review Request 59011: Fixed docker/appc store 'using' format.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59011/
-----------------------------------------------------------
Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
Repository: mesos
Description
-------
Fixed docker/appc store 'using' format.
Diffs
-----
include/mesos/appc/spec.hpp e9430df03b49f49d367e19b18991ead77fe5b830
src/slave/containerizer/mesos/provisioner/appc/store.cpp 09a40a5835454bb7519d11bae4a851337a89b935
src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2
src/slave/containerizer/mesos/provisioner/store.cpp 7141d63fcf2dbc3fbf00508c7f92945aab014fb2
Diff: https://reviews.apache.org/r/59011/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 59011: Fixed docker/appc store 'using' format.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59011/
-----------------------------------------------------------
(Updated May 22, 2017, 10:57 a.m.)
Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Fixed docker/appc store 'using' format.
Diffs (updated)
-----
include/mesos/appc/spec.hpp e9430df03b49f49d367e19b18991ead77fe5b830
src/slave/containerizer/mesos/provisioner/appc/store.cpp 09a40a5835454bb7519d11bae4a851337a89b935
src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2
src/slave/containerizer/mesos/provisioner/store.cpp 7141d63fcf2dbc3fbf00508c7f92945aab014fb2
Diff: https://reviews.apache.org/r/59011/diff/2/
Changes: https://reviews.apache.org/r/59011/diff/1-2/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 59011: Fixed docker/appc store 'using' format.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59011/#review174250
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 4, 2017, 11:22 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59011/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 11:22 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed docker/appc store 'using' format.
>
>
> Diffs
> -----
>
> include/mesos/appc/spec.hpp e9430df03b49f49d367e19b18991ead77fe5b830
> src/slave/containerizer/mesos/provisioner/appc/store.cpp 09a40a5835454bb7519d11bae4a851337a89b935
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2
> src/slave/containerizer/mesos/provisioner/store.cpp 7141d63fcf2dbc3fbf00508c7f92945aab014fb2
>
>
> Diff: https://reviews.apache.org/r/59011/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59011: Fixed docker/appc store 'using' format.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59011/#review174028
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 4, 2017, 11:22 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59011/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 11:22 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed docker/appc store 'using' format.
>
>
> Diffs
> -----
>
> include/mesos/appc/spec.hpp e9430df03b49f49d367e19b18991ead77fe5b830
> src/slave/containerizer/mesos/provisioner/appc/store.cpp 09a40a5835454bb7519d11bae4a851337a89b935
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2
> src/slave/containerizer/mesos/provisioner/store.cpp 7141d63fcf2dbc3fbf00508c7f92945aab014fb2
>
>
> Diff: https://reviews.apache.org/r/59011/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>