You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/19 08:44:07 UTC
[GitHub] [flink] rmetzger opened a new pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
rmetzger opened a new pull request #14694:
URL: https://github.com/apache/flink/pull/14694
## What is the purpose of the change
Increase stability of java e2e tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560208530
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -128,7 +128,11 @@ public Path getOrDownload(final String url, final Path targetDir) throws IOExcep
Files.createDirectories(scopedDownloadDir);
log.info("Downloading {}.", url);
AutoClosableProcess.create(
- CommandLineWrapper.wget(url).targetDir(scopedDownloadDir).build())
+ CommandLineWrapper.wget(url)
+ .targetDir(scopedDownloadDir)
+ .timeoutSecs(
+ downloadGlobalTimeout.getSeconds() / downloadMaxRetries)
Review comment:
overlooked it, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762693087
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d (Tue Jan 19 08:46:11 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560315240
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/CommandLineWrapper.java
##########
@@ -35,6 +36,7 @@ public static WGetBuilder wget(String url) {
private final String url;
private Path targetDir;
+ private int timeoutSecs;
Review comment:
`Duration#getSeconds` returns a `long`; this currently fails compilation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-763441149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560067730
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -199,7 +199,7 @@ jobs:
condition: not(eq(variables['SKIP'], '1'))
- task: Cache@2
inputs:
- key: e2e-cache | flink-end-to-end-tests/**/*.java, !**/avro/**
Review comment:
what is this for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #14694:
URL: https://github.com/apache/flink/pull/14694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560067499
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -128,7 +128,11 @@ public Path getOrDownload(final String url, final Path targetDir) throws IOExcep
Files.createDirectories(scopedDownloadDir);
log.info("Downloading {}.", url);
AutoClosableProcess.create(
- CommandLineWrapper.wget(url).targetDir(scopedDownloadDir).build())
+ CommandLineWrapper.wget(url)
+ .targetDir(scopedDownloadDir)
+ .timeoutSecs(
+ downloadGlobalTimeout.getSeconds() / downloadMaxRetries)
Review comment:
shouldn't this use the `downloadAttemptTimeout`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
}, {
"hash" : "e119c9031124430fb5bb93314c0d09826730b24a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248",
"triggerID" : "e119c9031124430fb5bb93314c0d09826730b24a",
"triggerType" : "PUSH"
}, {
"hash" : "0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12253",
"triggerID" : "0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560209321
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -199,7 +199,7 @@ jobs:
condition: not(eq(variables['SKIP'], '1'))
- task: Cache@2
inputs:
- key: e2e-cache | flink-end-to-end-tests/**/*.java, !**/avro/**
Review comment:
I believe the e2e cache never really worked, as it included only *.java files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
}, {
"hash" : "e119c9031124430fb5bb93314c0d09826730b24a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248",
"triggerID" : "e119c9031124430fb5bb93314c0d09826730b24a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e119c9031124430fb5bb93314c0d09826730b24a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
}, {
"hash" : "e119c9031124430fb5bb93314c0d09826730b24a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248",
"triggerID" : "e119c9031124430fb5bb93314c0d09826730b24a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222)
* e119c9031124430fb5bb93314c0d09826730b24a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
}, {
"hash" : "e119c9031124430fb5bb93314c0d09826730b24a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e119c9031124430fb5bb93314c0d09826730b24a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222)
* e119c9031124430fb5bb93314c0d09826730b24a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560068264
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/CommandLineWrapper.java
##########
@@ -45,6 +46,11 @@ public WGetBuilder targetDir(Path dir) {
return this;
}
+ public WGetBuilder timeoutSecs(long secs) {
Review comment:
This should accept a Duration and internally convert it to whatever unit wget expects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560313932
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -199,7 +199,7 @@ jobs:
condition: not(eq(variables['SKIP'], '1'))
- task: Cache@2
inputs:
- key: e2e-cache | flink-end-to-end-tests/**/*.java, !**/avro/**
Review comment:
But isn't this line just a `key` to determine whether a cache should be used, and not an inclusion filter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762693087
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c (Fri May 28 07:11:26 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19158).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
}, {
"hash" : "e119c9031124430fb5bb93314c0d09826730b24a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248",
"triggerID" : "e119c9031124430fb5bb93314c0d09826730b24a",
"triggerType" : "PUSH"
}, {
"hash" : "0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e119c9031124430fb5bb93314c0d09826730b24a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248)
* 0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14694:
URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12222",
"triggerID" : "1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d",
"triggerType" : "PUSH"
}, {
"hash" : "e119c9031124430fb5bb93314c0d09826730b24a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248",
"triggerID" : "e119c9031124430fb5bb93314c0d09826730b24a",
"triggerType" : "PUSH"
}, {
"hash" : "0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12253",
"triggerID" : "0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e119c9031124430fb5bb93314c0d09826730b24a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12248)
* 0fa938cf1ea77211be91a8fb3cd8e2cbc13de02c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560441105
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -199,7 +199,7 @@ jobs:
condition: not(eq(variables['SKIP'], '1'))
- task: Cache@2
inputs:
- key: e2e-cache | flink-end-to-end-tests/**/*.java, !**/avro/**
Review comment:
gosh, not sure what's going on with my brain. You are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org