You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/10 04:05:33 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29992: [SPARK-32881][CORE] Catch some race condition errors and log them more clearly
dongjoon-hyun commented on a change in pull request #29992:
URL: https://github.com/apache/spark/pull/29992#discussion_r502742624
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -380,16 +380,22 @@ class BlockManagerMasterEndpoint(
* @return Seq of ReplicateBlock
*/
private def getReplicateInfoForRDDBlocks(blockManagerId: BlockManagerId): Seq[ReplicateBlock] = {
- val info = blockManagerInfo(blockManagerId)
+ try {
+ val info = blockManagerInfo(blockManagerId)
- val rddBlocks = info.blocks.keySet().asScala.filter(_.isRDD)
- rddBlocks.map { blockId =>
- val currentBlockLocations = blockLocations.get(blockId)
- val maxReplicas = currentBlockLocations.size + 1
- val remainingLocations = currentBlockLocations.toSeq.filter(bm => bm != blockManagerId)
- val replicateMsg = ReplicateBlock(blockId, remainingLocations, maxReplicas)
- replicateMsg
- }.toSeq
+ val rddBlocks = info.blocks.keySet().asScala.filter(_.isRDD)
+ rddBlocks.map { blockId =>
+ val currentBlockLocations = blockLocations.get(blockId)
+ val maxReplicas = currentBlockLocations.size + 1
+ val remainingLocations = currentBlockLocations.toSeq.filter(bm => bm != blockManagerId)
+ val replicateMsg = ReplicateBlock(blockId, remainingLocations, maxReplicas)
+ replicateMsg
+ }.toSeq
+ } catch {
+ // If the block manager has already exited, nothing to replicate.
+ case e: java.util.NoSuchElementException =>
Review comment:
Shall we import?
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -380,16 +380,22 @@ class BlockManagerMasterEndpoint(
* @return Seq of ReplicateBlock
*/
private def getReplicateInfoForRDDBlocks(blockManagerId: BlockManagerId): Seq[ReplicateBlock] = {
- val info = blockManagerInfo(blockManagerId)
+ try {
+ val info = blockManagerInfo(blockManagerId)
- val rddBlocks = info.blocks.keySet().asScala.filter(_.isRDD)
- rddBlocks.map { blockId =>
- val currentBlockLocations = blockLocations.get(blockId)
- val maxReplicas = currentBlockLocations.size + 1
- val remainingLocations = currentBlockLocations.toSeq.filter(bm => bm != blockManagerId)
- val replicateMsg = ReplicateBlock(blockId, remainingLocations, maxReplicas)
- replicateMsg
- }.toSeq
+ val rddBlocks = info.blocks.keySet().asScala.filter(_.isRDD)
+ rddBlocks.map { blockId =>
+ val currentBlockLocations = blockLocations.get(blockId)
+ val maxReplicas = currentBlockLocations.size + 1
+ val remainingLocations = currentBlockLocations.toSeq.filter(bm => bm != blockManagerId)
+ val replicateMsg = ReplicateBlock(blockId, remainingLocations, maxReplicas)
+ replicateMsg
+ }.toSeq
+ } catch {
+ // If the block manager has already exited, nothing to replicate.
+ case e: java.util.NoSuchElementException =>
Review comment:
Also, it would be great if we have a warning log here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org