You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/28 09:27:19 UTC
[GitHub] [cordova-android] NiklasMerz opened a new pull request #1222: add backwards compatibility mode for WebViewAssetLoader
NiklasMerz opened a new pull request #1222:
URL: https://github.com/apache/cordova-android/pull/1222
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
As we discussed on the list we might need a fallback for the new changes in #1137
With this PR you can fall back to using files instead of https://localhost with this preference:
`
<preference name="InsecureFileMode" value="true" />
`
# ToDo
<!-- Describe your changes in detail -->
* Decide on name for preference
* Document
* Hightlight in Annoucement
### Testing
<!-- Please describe in detail how you tested your changes. -->
Manual
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] NiklasMerz commented on a change in pull request #1222: feat: add backwards compatibility mode for WebViewAssetLoader
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on a change in pull request #1222:
URL: https://github.com/apache/cordova-android/pull/1222#discussion_r625072912
##########
File path: framework/src/org/apache/cordova/ConfigXmlParser.java
##########
@@ -46,9 +46,14 @@ public CordovaPreferences getPreferences() {
}
public String getLaunchUrl() {
- if (launchUrl == null) {
+ if (launchUrl == null) {
Review comment:
You are right. I just pushed another change with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1222: add backwards compatibility mode for WebViewAssetLoader
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1222:
URL: https://github.com/apache/cordova-android/pull/1222#issuecomment-828305429
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1222](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ff9638) into [master](https://codecov.io/gh/apache/cordova-android/commit/f9e8ce8fab7c4005e110c35fcdcb3ea71e92d41c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9e8ce8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 71.97% 71.97%
=======================================
Files 21 21
Lines 1695 1695
=======================================
Hits 1220 1220
Misses 475 475
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f9e8ce8...7ff9638](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1222: add backwards compatibility mode for WebViewAssetLoader
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1222:
URL: https://github.com/apache/cordova-android/pull/1222#issuecomment-828305429
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1222](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ff9638) into [master](https://codecov.io/gh/apache/cordova-android/commit/f9e8ce8fab7c4005e110c35fcdcb3ea71e92d41c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9e8ce8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 71.97% 71.97%
=======================================
Files 21 21
Lines 1695 1695
=======================================
Hits 1220 1220
Misses 475 475
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f9e8ce8...7ff9638](https://codecov.io/gh/apache/cordova-android/pull/1222?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] PieterVanPoyer commented on a change in pull request #1222: feat: add backwards compatibility mode for WebViewAssetLoader
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on a change in pull request #1222:
URL: https://github.com/apache/cordova-android/pull/1222#discussion_r625066741
##########
File path: framework/src/org/apache/cordova/ConfigXmlParser.java
##########
@@ -46,9 +46,14 @@ public CordovaPreferences getPreferences() {
}
public String getLaunchUrl() {
- if (launchUrl == null) {
+ if (launchUrl == null) {
Review comment:
Nice work!
But, just a quick question.
There is also a setStartUrl method. The launchUrl is also prefixed with https there.
https://github.com/apache/cordova-android/pull/1222/files#diff-a32677abc0f97a96abd2948fad9d6b12f1251645a9f330431862dc83dabaeae2R150
Should it be prefixed with file if the AndroidInsecureFileModeEnabled returns true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] NiklasMerz merged pull request #1222: feat: add backwards compatibility mode for WebViewAssetLoader
Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #1222:
URL: https://github.com/apache/cordova-android/pull/1222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org