[GitHub] [airflow] mhenc commented on a diff in pull request #28476: Migrate DagFileProcessorManager._deactivate_stale_dags to Internal API

[GitBox <gi...@apache.org>]

mhenc commented on code in PR #28476:
URL: https://github.com/apache/airflow/pull/28476#discussion_r1053049315


##########
airflow/dag_processing/manager.py:
##########
@@ -485,51 +486,69 @@ def start(self):
         return self._run_parsing_loop()
 
     @provide_session
-    def _deactivate_stale_dags(self, session=None):
-        """
-        Detects DAGs which are no longer present in files.
-
-        Deactivate them and remove them in the serialized_dag table
-        """
+    def _scan_stale_dags(self, session=None):

Review Comment:
   I think we can remove the session param (and @provide_session) from this method.



##########
airflow/api_internal/endpoints/rpc_api_endpoint.py:
##########
@@ -68,7 +70,10 @@ def internal_airflow_api(
 
     log.debug("Calling method %.", {method_name})
     try:
-        output = handler(**params)
+        output = handler(
+            **params,
+            log=logging.getLogger(f"airflow.internal_api.{method_name}"),

Review Comment:
   Does it work if the method doesn't have "log" parameter?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org