You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/07/31 19:03:59 UTC
Review Request 72726: Fixed a bug in CSI volume manager
initialization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72726/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Previously, the volume managers would assume that they could
make CONTROLLER_SERVICE calls during plugin initialization,
regardless of whether or not the plugin provides that service.
Diffs
-----
src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
Diff: https://reviews.apache.org/r/72726/diff/1/
Testing
-------
This change is necessary for a subsequent test later in this chain to pass.
Thanks,
Greg Mann
Re: Review Request 72726: Fixed a bug in CSI volume manager
initialization.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Aug. 3, 2020, 1:16 a.m., Qian Zhang wrote:
> > src/csi/v0_volume_manager.cpp
> > Lines 645-651 (original), 645-651 (patched)
> > <https://reviews.apache.org/r/72726/diff/1/?file=2236763#file2236763line645>
> >
> > I am a bit confused about the purpose of this code. This is a `foreach` loop for `services`, but in each iteration of the loop we always use the **first service** (i.e. `*services.begin()`) or the **CONTROLLER_SERVICE** (the old code) to make the `getPluginInfo` call. And in the code below, we compare the result of each call, but I think they must be consistent since we make the exactly same call in each iteration, right?
> >
> > So I guess we should make the `getPluginInfo` call with the `service` variable as the first parameter, right?
Whoops sorry!!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72726/#review221449
-----------------------------------------------------------
On Aug. 3, 2020, 7:05 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72726/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2020, 7:05 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the volume managers would assume that they could
> make CONTROLLER_SERVICE calls during plugin initialization,
> regardless of whether or not the plugin provides that service.
>
>
> Diffs
> -----
>
> src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423
> src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56
>
>
> Diff: https://reviews.apache.org/r/72726/diff/2/
>
>
> Testing
> -------
>
> This change is necessary for a subsequent test later in this chain to pass.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72726: Fixed a bug in CSI volume manager
initialization.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72726/#review221449
-----------------------------------------------------------
src/csi/v0_volume_manager.cpp
Lines 645-651 (original), 645-651 (patched)
<https://reviews.apache.org/r/72726/#comment310465>
I am a bit confused about the purpose of this code. This is a `foreach` loop for `services`, but in each iteration of the loop we always use the **first service** (i.e. `*services.begin()`) or the **CONTROLLER_SERVICE** (the old code) to make the `getPluginInfo` call. And in the code below, we compare the result of each call, but I think they must be consistent since we make the exactly same call in each iteration, right?
So I guess we should make the `getPluginInfo` call with the `service` variable as the first parameter, right?
- Qian Zhang
On Aug. 1, 2020, 3:03 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72726/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2020, 3:03 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the volume managers would assume that they could
> make CONTROLLER_SERVICE calls during plugin initialization,
> regardless of whether or not the plugin provides that service.
>
>
> Diffs
> -----
>
> src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
> src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
>
>
> Diff: https://reviews.apache.org/r/72726/diff/1/
>
>
> Testing
> -------
>
> This change is necessary for a subsequent test later in this chain to pass.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72726: Fixed a bug in CSI volume manager
initialization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72726/
-----------------------------------------------------------
(Updated Aug. 12, 2020, 7:03 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Previously, the volume managers would assume that they could
make CONTROLLER_SERVICE calls during plugin initialization,
regardless of whether or not the plugin provides that service.
Diffs
-----
src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423
src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56
Diff: https://reviews.apache.org/r/72726/diff/2/
Testing
-------
This change is necessary for a subsequent test later in this chain to pass.
Thanks,
Greg Mann
Re: Review Request 72726: Fixed a bug in CSI volume manager
initialization.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72726/#review221461
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 4, 2020, 3:05 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72726/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2020, 3:05 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the volume managers would assume that they could
> make CONTROLLER_SERVICE calls during plugin initialization,
> regardless of whether or not the plugin provides that service.
>
>
> Diffs
> -----
>
> src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423
> src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56
>
>
> Diff: https://reviews.apache.org/r/72726/diff/2/
>
>
> Testing
> -------
>
> This change is necessary for a subsequent test later in this chain to pass.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72726: Fixed a bug in CSI volume manager
initialization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72726/
-----------------------------------------------------------
(Updated Aug. 3, 2020, 7:05 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Previously, the volume managers would assume that they could
make CONTROLLER_SERVICE calls during plugin initialization,
regardless of whether or not the plugin provides that service.
Diffs (updated)
-----
src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423
src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56
Diff: https://reviews.apache.org/r/72726/diff/2/
Changes: https://reviews.apache.org/r/72726/diff/1-2/
Testing
-------
This change is necessary for a subsequent test later in this chain to pass.
Thanks,
Greg Mann