[GitHub] [bookkeeper] nicoloboschi commented on a diff in pull request #3314: Remove gradle from workflow

[GitBox <gi...@apache.org>]

nicoloboschi commented on code in PR #3314:
URL: https://github.com/apache/bookkeeper/pull/3314#discussion_r891334311


##########
.github/workflows/backward-compat-tests.yml:
##########
@@ -49,10 +49,17 @@ jobs:
         with:
           java-version: 1.8
       - name: Build
-        run: ./gradlew stream:server:build -x test ${GRADLE_ARGS}
+        run: mvn -B -nsu -am -pl :stream-storage-server clean install
       - name: Test current server with old clients
-        run: ./gradlew :tests:backward-compat:current-server-old-clients:test ${GRADLE_ARGS} || (tail -n +1 tests/backward-compat/current-server-old-clients/build/reports/tests/test/classes/* && tail -n +1 tests/backward-compat/current-server-old-clients/build/container-logs/**/* && exit 1)
+        run: mvn -B -nsu -am -pl :backward-compat-current-server-old-clients test

Review Comment:
   -am is not needed if the maven phase is "test" 
   In this case will run the tests for every dependant module ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org