You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/01 10:34:16 UTC

[GitHub] [apisix-ingress-controller] Sindweller opened a new pull request #731: feat: Grafana Dashboard Configuration

Sindweller opened a new pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731


   Please answer these questions before submitting a pull request
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   This pr has a prior pr #670 .
   A shortcut of Grafana Dashboard for apisix-ingress-controller:
   <img width="1708" alt="grafana-1" src="https://user-images.githubusercontent.com/59216361/139658180-5aa4dc8f-9b9e-4b59-ab59-fb20f7eff579.png">
   <img width="1785" alt="grafana-2" src="https://user-images.githubusercontent.com/59216361/139658250-b5f5680c-9c8f-443a-8e6d-5d3bd28c0c44.png">
   
   ![grafana-3](https://user-images.githubusercontent.com/59216361/139658579-4c114a0c-b052-45fb-a5a8-889dd87e19a4.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #731: docs: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-978778888


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#731](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4affd60) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b127ff4) will **increase** coverage by `0.64%`.
   > The diff coverage is `34.24%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #731      +/-   ##
   ==========================================
   + Coverage   32.50%   33.14%   +0.64%     
   ==========================================
     Files          66       67       +1     
     Lines        6800     7142     +342     
   ==========================================
   + Hits         2210     2367     +157     
   - Misses       4340     4505     +165     
   - Partials      250      270      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `72.72% <ø> (-2.28%)` | :arrow_down: |
   | [pkg/api/validation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL2FwaXNpeF9jb25zdW1lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/api/validation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL2FwaXNpeF9yb3V0ZS5nbw==) | `21.73% <0.00%> (+2.50%)` | :arrow_up: |
   | [pkg/api/validation/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL2FwaXNpeF90bHMuZ28=) | `0.00% <0.00%> (ø)` | |
   | [pkg/api/validation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL2FwaXNpeF91cHN0cmVhbS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | |
   | [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
   | [pkg/ingress/apisix\_cluster\_config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NvbnN1bWVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
   | ... and [37 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b127ff4...4affd60](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r771891099



##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -0,0 +1,124 @@
+---
+title: prometheus
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+This guide shows how to monitor Apache APISIX Ingress Controller using Prometheus and Grafana.
+
+## Enable Prometheus
+
+You can find example CRD files in `apisix-ingress-controller/samples/deploy/crd/v1`.  
+The CRD file `ApisixClusterConfig` is required to use to enable prometheus in global configurations.  
+In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe Prometheus settings.
+```yaml

Review comment:
       This file is a definition file for custom resources. In order to be able to configure correctly, we should create a custom resource configuration file, like this:
   
   ```yaml
   apiVersion: apisix.apache.org/v2beta3
   kind: ApisixClusterConfig
   metadata:
     name: default
   spec:
     monitoring:
       prometheus:
         enable: true
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Sindweller commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
Sindweller commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-981660128


   > @Sindweller What does the `cluster health check` value mean?
   
   It increases when [checkClusterHealth](https://github.com/apache/apisix-ingress-controller/blob/f4708675c6304ad019881ad7e0ac7a0affd3e6bd/pkg/ingress/controller.go#L642) is called to record a successful health check for default cluster. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-978785418


   Can you add a document describing how to monitor and use this dashboard? Thanks 
   
   If you need any help please feel free to ping me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-981461097


   @Sindweller What does the `cluster health check` value mean?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-1003265292


   @Sindweller LGTM. Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-982207316


   > > @Sindweller What does the `cluster health check` value mean?
   > 
   > It increases when [checkClusterHealth](https://github.com/apache/apisix-ingress-controller/blob/f4708675c6304ad019881ad7e0ac7a0affd3e6bd/pkg/ingress/controller.go#L642) is called to record a successful health check for default cluster.
   
   OK, so what about APISIX Health Check Calls, so that we know the usage of this metrics.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-977839782


   ping @Sindweller any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918990



##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -0,0 +1,124 @@
+---
+title: prometheus
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+This guide shows how to monitor Apache APISIX Ingress Controller using Prometheus and Grafana.
+
+## Enable Prometheus
+
+You can find example CRD files in `apisix-ingress-controller/samples/deploy/crd/v1`.  
+The CRD file `ApisixClusterConfig` is required to use to enable prometheus in global configurations.  
+In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe Prometheus settings.
+```yaml

Review comment:
       looks good.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-978778888


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#731](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6628406) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/65f7c88193eb6e83b2bb4ca87a981321a99503e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65f7c88) will **increase** coverage by `0.49%`.
   > The diff coverage is `52.54%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #731      +/-   ##
   ==========================================
   + Coverage   31.70%   32.19%   +0.49%     
   ==========================================
     Files          66       65       -1     
     Lines        6640     6799     +159     
   ==========================================
   + Hits         2105     2189      +84     
   - Misses       4280     4353      +73     
   - Partials      255      257       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/ingress/apisix\_cluster\_config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NvbnN1bWVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Vwc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.00% <0.00%> (-0.01%)` | :arrow_down: |
   | [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/endpointslice.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnRzbGljZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `8.10% <0.00%> (-0.19%)` | :arrow_down: |
   | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | |
   | ... and [16 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [65f7c88...6628406](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Sindweller commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
Sindweller commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-981651080


   > Can you add a document describing how to monitor and use this dashboard? Thanks
   > 
   > If you need any help please feel free to ping me.
   
   working on it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Sindweller commented on a change in pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
Sindweller commented on a change in pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918809



##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -0,0 +1,124 @@
+---
+title: prometheus
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+This guide shows how to monitor Apache APISIX Ingress Controller using Prometheus and Grafana.
+
+## Enable Prometheus
+
+You can find example CRD files in `apisix-ingress-controller/samples/deploy/crd/v1`.  
+The CRD file `ApisixClusterConfig` is required to use to enable prometheus in global configurations.  
+In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe Prometheus settings.
+```yaml

Review comment:
       please see if I understand the usage of crd file.
   (in current commit)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Sindweller commented on a change in pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
Sindweller commented on a change in pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918809



##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -0,0 +1,124 @@
+---
+title: prometheus
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+This guide shows how to monitor Apache APISIX Ingress Controller using Prometheus and Grafana.
+
+## Enable Prometheus
+
+You can find example CRD files in `apisix-ingress-controller/samples/deploy/crd/v1`.  
+The CRD file `ApisixClusterConfig` is required to use to enable prometheus in global configurations.  
+In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe Prometheus settings.
+```yaml

Review comment:
       please see if I understand the usage of crd file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #731:
URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-1003258223


   @Sindweller Thanks! It looks great to me!
   
   Please fix the markdown lint error. Then we can merge this one. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org