You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/20 18:54:10 UTC

[GitHub] [spark] rdblue commented on issue #26678: [SPARK-30226][SQL] Remove withXXX functions in WriteBuilder

rdblue commented on issue #26678: [SPARK-30226][SQL] Remove withXXX functions in WriteBuilder
URL: https://github.com/apache/spark/pull/26678#issuecomment-568043697
 
 
   I think there are other ways to ensure you're using a builder correctly. For one thing, adding validations to the internal implementations makes sense.
   
   In general, we need to stop making breaking changes to the API simply because it is marginally better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org