[jira] [Commented] (FLINK-9576) Wrong contiguity documentation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533771#comment-16533771 ] 

ASF GitHub Bot commented on FLINK-9576:
---------------------------------------

GitHub user dawidwys opened a pull request:

    https://github.com/apache/flink/pull/6268

    [FLINK-9576] Fixed documentation for contiguity within looping pattern.

    Fixed example in the documentation plus restructured it a bit to make it more straightforward.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dawidwys/flink FLINK-9576

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6268
    
----
commit b569d4b951f173d3a7123381fa3dd2e9f1905019
Author: Dawid Wysakowicz <dw...@...>
Date:   2018-07-05T14:48:17Z

    [FLINK-9576] Fixed documentation for contiguity within looping pattern.

----


> Wrong contiguity documentation
> ------------------------------
>
>                 Key: FLINK-9576
>                 URL: https://issues.apache.org/jira/browse/FLINK-9576
>             Project: Flink
>          Issue Type: Bug
>          Components: CEP, Documentation
>            Reporter: Dawid Wysakowicz
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> Example for the contiguity is first of all wrong, and second of all misleading:
>  
> {code:java}
> To illustrate the above with an example, a pattern sequence "a+ b" (one or more "a"’s followed by a "b") with input "a1", "c", "a2", "b" will have the following results:
> Strict Contiguity: {a2 b} – the "c" after "a1" causes "a1" to be discarded.
> Relaxed Contiguity: {a1 b} and {a1 a2 b} – "c" is ignored.
> Non-Deterministic Relaxed Contiguity: {a1 b}, {a2 b}, and {a1 a2 b}.
> For looping patterns (e.g. oneOrMore() and times()) the default is relaxed contiguity. If you want strict contiguity, you have to explicitly specify it by using the consecutive() call, and if you want non-deterministic relaxed contiguity you can use the allowCombinations() call.
> {code}
>  
> Results for the relaxed contiguity are wrong plus they do not clearly explains the internal contiguity of kleene closure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)