[GitHub] [pulsar] sijie commented on a change in pull request #8310: [Offload] Make the field name in `OffloadPolicies` match with config file

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #8310:
URL: https://github.com/apache/pulsar/pull/8310#discussion_r508996045



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPolicies.java
##########
@@ -51,8 +51,8 @@
     private String managedLedgerOffloadDriver = null;
     private int managedLedgerOffloadMaxThreads = DEFAULT_OFFLOAD_MAX_THREADS;
     private int managedLedgerOffloadPrefetchRounds = DEFAULT_OFFLOAD_MAX_PREFETCH_ROUNDS;
-    private long managedLedgerOffloadThresholdInBytes = DEFAULT_OFFLOAD_THRESHOLD_IN_BYTES;
-    private Long managedLedgerOffloadDeletionLagInMillis = DEFAULT_OFFLOAD_DELETION_LAG_IN_MILLIS;
+    private long managedLedgerOffloadAutoTriggerSizeThresholdBytes = DEFAULT_OFFLOAD_THRESHOLD_IN_BYTES;

Review comment:
       What is the backward compatibility story here because we are changing the field name for `OffloadPolicies`? If there is already a namespace policy written using previous field names, how do we guarantee the new code is able to read the offload policies written using the old code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org