[GitHub] [incubator-eventmesh] horoc commented on a diff in pull request #2509: [Enhancement] Remove redundant parameter passing

[GitBox <gi...@apache.org>]

horoc commented on code in PR #2509:
URL: https://github.com/apache/incubator-eventmesh/pull/2509#discussion_r1043212767


##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java:
##########
@@ -123,12 +123,12 @@ private String checkNotEmpty(String key) {
         return value;
     }
 
-    private String checkNumeric(String key) {
-        String value = configurationWrapper.getProp(key);
+    private String checkNumeric() {
+        String value = configurationWrapper.getProp(ConfKeys.KEYS_EVENTMESH_SYSID);

Review Comment:
   I think the method `private String checkNumeric(String key)`  here is introduced as a common method to check the numeric property,  if we remove the key parameter and just use `checkNumeric()` to get specific property,  the method name would be very confusing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org