[GitHub] [hive] marton-bod commented on a change in pull request #1857: HIVE-24629: Invoke output committer in TezProcessor

[GitBox <gi...@apache.org>]

marton-bod commented on a change in pull request #1857:
URL: https://github.com/apache/hive/pull/1857#discussion_r558236568



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java
##########
@@ -1600,9 +1601,14 @@ public Vertex createVertex(JobConf conf, BaseWork workUnit, Path scratchDir,
     // final vertices need to have at least one output
     boolean endVertex = tezWork.getLeaves().contains(workUnit);
     if (endVertex) {
+      OutputCommitterDescriptor ocd = null;
+      if (conf.get("hive.tez.mapreduce.output.committer.class") != null
+          && conf.get("mapred.output.committer.class") != null) {

Review comment:
       After thinking about it, we shouldn't have this check. Just because `MROutputCommitter` delegates all the calls to an inner committer object (implementation of this inner field is determined by `mapred.output.committer.class`), it doesn't mean all Tez output committer implementations should or will in the future. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org