You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/07 02:07:10 UTC
[GitHub] [apisix] Yiyiyimu opened a new pull request #3542: fix: make deps error: file changed as we read it
Yiyiyimu opened a new pull request #3542:
URL: https://github.com/apache/apisix/pull/3542
Signed-off-by: yiyiyimu <wo...@gmail.com>
### What this PR does / why we need it:
There are error `tar: .: file changed as we read it` when do `make deps`, and the reason is the argument `--exclude $(RELEASE_SRC).tgz` seems not working, so that the tarball is changing as it's being built.
So move it to a separate path to avoid this problem.
Some other problems would be fixed with https://github.com/apache/apisix/commit/63f779aeae7a4cfdc3baa5c6dad955ef139719f8
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3542: fix: make deps error: file changed as we read it
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3542:
URL: https://github.com/apache/apisix/pull/3542#discussion_r571517208
##########
File path: Makefile
##########
@@ -238,13 +239,7 @@ release-src:
--exclude t \
--exclude utils \
--exclude release \
- --exclude $(RELEASE_SRC).tgz \
Review comment:
We already switch to a whitelist solution: https://github.com/apache/apisix/pull/3466/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu closed pull request #3542: fix: make deps error: file changed as we read it
Posted by GitBox <gi...@apache.org>.
Yiyiyimu closed pull request #3542:
URL: https://github.com/apache/apisix/pull/3542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3542: fix: make deps error: file changed as we read it
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3542:
URL: https://github.com/apache/apisix/pull/3542#discussion_r571531395
##########
File path: Makefile
##########
@@ -238,13 +239,7 @@ release-src:
--exclude t \
--exclude utils \
--exclude release \
- --exclude $(RELEASE_SRC).tgz \
Review comment:
Cool I didn't realize whitelist could solve this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org