You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2017/01/17 21:25:55 UTC

Review Request 55645: GEODE-2293: The AckReaderThread incorrectly shuts down when an IllegalStateException is thrown while releasing an off-heap object

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55645/
-----------------------------------------------------------

Review request for geode and Barry Oglesby.


Bugs: GEODE-2293
    https://issues.apache.org/jira/browse/GEODE-2293


Repository: geode


Description
-------

Removed some dead code
Added try catch around the call to the release() method


Diffs
-----

  geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 820cd99 
  geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 69a887b 
  geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java c6d7c00 
  geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java e9e0c94 

Diff: https://reviews.apache.org/r/55645/diff/


Testing
-------


Thanks,

Jason Huynh


Re: Review Request 55645: GEODE-2293: The AckReaderThread incorrectly shuts down when an IllegalStateException is thrown while releasing an off-heap object

Posted by Jason Huynh <jh...@pivotal.io>.

> On Jan. 17, 2017, 9:42 p.m., Barry Oglesby wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java, line 1099
> > <https://reviews.apache.org/r/55645/diff/1/?file=1606972#file1606972line1099>
> >
> >     I think I would add a message to this error saying the thread will continue. Just so if a customer or one of us sees it in the log, we'll know its not fatal for the thread.

Good idea, will change this.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55645/#review161962
-----------------------------------------------------------


On Jan. 17, 2017, 9:25 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55645/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 9:25 p.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Bugs: GEODE-2293
>     https://issues.apache.org/jira/browse/GEODE-2293
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Removed some dead code
> Added try catch around the call to the release() method
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 820cd99 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 69a887b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java c6d7c00 
>   geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java e9e0c94 
> 
> Diff: https://reviews.apache.org/r/55645/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55645: GEODE-2293: The AckReaderThread incorrectly shuts down when an IllegalStateException is thrown while releasing an off-heap object

Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55645/#review161962
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java (line 1099)
<https://reviews.apache.org/r/55645/#comment233227>

    I think I would add a message to this error saying the thread will continue. Just so if a customer or one of us sees it in the log, we'll know its not fatal for the thread.


- Barry Oglesby


On Jan. 17, 2017, 9:25 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55645/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 9:25 p.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Bugs: GEODE-2293
>     https://issues.apache.org/jira/browse/GEODE-2293
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Removed some dead code
> Added try catch around the call to the release() method
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 820cd99 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 69a887b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java c6d7c00 
>   geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java e9e0c94 
> 
> Diff: https://reviews.apache.org/r/55645/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55645: GEODE-2293: The AckReaderThread incorrectly shuts down when an IllegalStateException is thrown while releasing an off-heap object

Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55645/#review161992
-----------------------------------------------------------


Ship it!




Ship It!

- Barry Oglesby


On Jan. 17, 2017, 11:36 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55645/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 11:36 p.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Bugs: GEODE-2293
>     https://issues.apache.org/jira/browse/GEODE-2293
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Removed some dead code
> Added try catch around the call to the release() method
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 820cd99 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 69a887b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java c6d7c00 
>   geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java e9e0c94 
> 
> Diff: https://reviews.apache.org/r/55645/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55645: GEODE-2293: The AckReaderThread incorrectly shuts down when an IllegalStateException is thrown while releasing an off-heap object

Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55645/
-----------------------------------------------------------

(Updated Jan. 17, 2017, 11:36 p.m.)


Review request for geode and Barry Oglesby.


Bugs: GEODE-2293
    https://issues.apache.org/jira/browse/GEODE-2293


Repository: geode


Description
-------

Removed some dead code
Added try catch around the call to the release() method


Diffs (updated)
-----

  geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 820cd99 
  geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 69a887b 
  geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java c6d7c00 
  geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java e9e0c94 

Diff: https://reviews.apache.org/r/55645/diff/


Testing
-------


Thanks,

Jason Huynh