You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <br...@apache.org> on 2016/06/08 08:35:58 UTC
[BCEL] Latest Clirr report
Hi all,
I've published the BCEL website after reverting the package rename. Here
[1] is the Clirr report of the current code base.
Benedikt
[1] http://commons.apache.org/proper/commons-bcel/clirr-report.html
Re: Re: [BCEL] Latest Clirr report
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Tue, Jun 14, 2016 at 8:24 AM, Benedikt Ritter <br...@apache.org> wrote:
> Andrey Loskutov <lo...@gmx.de> schrieb am Mo., 13. Juni 2016 um
> 14:15 Uhr:
> Okay, so you would like to see an RC with the current state of trunk?!
+1
Jochen
--
The next time you hear: "Don't reinvent the wheel!"
http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: Re: Re: [BCEL] Latest Clirr report
Posted by Andrey Loskutov <lo...@gmx.de>.
> From: "Benedikt Ritter" <br...@apache.org>
> To: "Commons Developers List" <de...@commons.apache.org>
> Subject: Re: Re: [BCEL] Latest Clirr report
> > So from my limited FindBugs point of view we can release BCEL6 as it is
> > today on trunk.
> >
>
> Okay, so you would like to see an RC with the current state of trunk?!
Sure. Sooner is better, just to finish this impossible "10 years without release" state.
I hope to get some time to verify if FindBugs run with with RC over the weekend.
Regards,
Andrey
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: Re: [BCEL] Latest Clirr report
Posted by Benedikt Ritter <br...@apache.org>.
Andrey Loskutov <lo...@gmx.de> schrieb am Mo., 13. Juni 2016 um
14:15 Uhr:
> Hi,
>
> from FindBugs point of view, the biggest issue was the removal of
> "intermediate" org.apache.bcel.classfile.StackMapTable /
> org.apache.bcel.classfile.StackMapTableEntry classes. The removal of
> Serializable is not important for us at all, so I don't care.
>
> We had a discussion here on the list regarding StackMapTable* and as far
> as I understood, there is no plan to restore those two types.
>
> Therefore I've adopted FB code now (not on master, but soon) and included
> replacements for the missing classes to the binary distribution, so that
> the downstream plugins provider will at least do not crash due the missing
> classes. However, the behavior is changed and without source code
> adaptation code relied on those two classes will not work.
>
> I'va also tried (smoke tests) the biggest known (to me) plugin
> "fb-contrib" from Dave and found only one BC issue left -
> https://github.com/mebigfatguy/fb-contrib/issues/116.
>
> This was also caused by some refactorings in not released code
> (ParameterAnnotationEntry).
>
> So from my limited FindBugs point of view we can release BCEL6 as it is
> today on trunk.
>
Okay, so you would like to see an RC with the current state of trunk?!
Benedikt
>
> BTW, if you will, you can compare current BCEL 6 jar from trunk with the
> latest "FB BCEL patch" jar here:
> https://github.com/findbugsproject/findbugs/blob/master/findbugs/lib/bcel-6.0-SNAPSHOT.jar.
> I think Clirr should be able to do a diff here. Don't ask me from which
> revision this patched jar was created, I have no clue.
>
> This is the BCEL API state we "exported" to downstream since 3 years :-(
>
> Kind regards,
> Andrey Loskutov
>
> http://google.com/+AndreyLoskutov
>
>
> > Gesendet: Sonntag, 12. Juni 2016 um 14:12 Uhr
> > Von: sebb <se...@gmail.com>
> > An: "Commons Developers List" <de...@commons.apache.org>
> > Betreff: Re: [BCEL] Latest Clirr report
> >
> > On 12 June 2016 at 12:43, Benedikt Ritter <br...@apache.org> wrote:
> > > sebb <se...@gmail.com> schrieb am So., 12. Juni 2016 um 13:38 Uhr:
> > >
> > >> On 12 June 2016 at 12:00, Benedikt Ritter <br...@apache.org> wrote:
> > >> > Hi,
> > >> >
> > >> > I've uploaded the verbose Clirr report to my space at
> home.apache.org
> > >> [1].
> > >> > Do we have to fix all of this in order to release 6.0?
> > >>
> > >> No, most of the changes don't break strict BC.
> > >>
> > >> The main changes to the interfaces don't break BC and are highly
> > >> unlikely to affect source because there are abstract implementation
> > >> classes.
> > >>
> > >> See the changes.xml file and release notes for some details.
> > >>
> > >
> > > Thank you, I will have a look. Can we compile a list of things we need
> to
> > > fix for 6.0?
> >
> > Unfortunately the lack of updates has caused downstream users to rely
> > on non-released code.
> > I think we should try and ensure that we don't make things worse.
> >
> > Therefore I don't think we can compile a full list without assistance
> > from FindBugs and other consumers of the code.
> >
> > I suspect this will be an iterative process to try and find the best
> > compromise that suits these users as well as users who have only used
> > formal releases.
> >
> > > Benedikt
> > >
> > >
> > >>
> > >> > Benedikt
> > >> >
> > >> > [1]
> > >> >
> > >>
> http://home.apache.org/~britter/commons/bcel/6.0-SNAPSHOT/clirr-report.html
> > >> >
> > >> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:54 Uhr:
> > >> >
> > >> >> On 8 June 2016 at 10:46, Benedikt Ritter <br...@apache.org>
> wrote:
> > >> >> > Hello sebb,
> > >> >> >
> > >> >> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:21
> Uhr:
> > >> >> >
> > >> >> >> Was that the full report, or the 'quietened' one?
> > >> >> >> There's a Clirr suppression file which removes some diffs that
> are
> > >> >> >> considered non-breaking (as per the changes description)
> > >> >> >> (otherwise the report is rather difficult to read)
> > >> >> >>
> > >> >> >> To show all the errors, use -P!quieten-clirr or
> > >> -Dclirr.allDifferences
> > >> >> >>
> > >> >> >
> > >> >> > The report is the result of running mvn clean site. So if
> > >> quiten-clirr is
> > >> >> > activated by default it's the 'quitened' one (sorry I currently
> don't
> > >> >> have
> > >> >> > time to look into the pom).
> > >> >>
> > >> >> Yes, it is the default.
> > >> >>
> > >> >> > I can upload the "real" report to home.apache.org tonight when
> I'm at
> > >> >> home.
> > >> >>
> > >> >> OK, thanks.
> > >> >>
> > >> >> > Benedikt
> > >> >> >
> > >> >> >
> > >> >> >>
> > >> >> >> On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org>
> wrote:
> > >> >> >> > Hi all,
> > >> >> >> >
> > >> >> >> > I've published the BCEL website after reverting the package
> rename.
> > >> >> Here
> > >> >> >> > [1] is the Clirr report of the current code base.
> > >> >> >> >
> > >> >> >> > Benedikt
> > >> >> >> >
> > >> >> >> > [1]
> > >> http://commons.apache.org/proper/commons-bcel/clirr-report.html
> > >> >> >>
> > >> >> >>
> ---------------------------------------------------------------------
> > >> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >> >> >> For additional commands, e-mail: dev-help@commons.apache.org
> > >> >> >>
> > >> >> >>
> > >> >>
> > >> >>
> ---------------------------------------------------------------------
> > >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >> >> For additional commands, e-mail: dev-help@commons.apache.org
> > >> >>
> > >> >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >> For additional commands, e-mail: dev-help@commons.apache.org
> > >>
> > >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: Re: [BCEL] Latest Clirr report
Posted by Andrey Loskutov <lo...@gmx.de>.
Hi,
from FindBugs point of view, the biggest issue was the removal of "intermediate" org.apache.bcel.classfile.StackMapTable / org.apache.bcel.classfile.StackMapTableEntry classes. The removal of Serializable is not important for us at all, so I don't care.
We had a discussion here on the list regarding StackMapTable* and as far as I understood, there is no plan to restore those two types.
Therefore I've adopted FB code now (not on master, but soon) and included replacements for the missing classes to the binary distribution, so that the downstream plugins provider will at least do not crash due the missing classes. However, the behavior is changed and without source code adaptation code relied on those two classes will not work.
I'va also tried (smoke tests) the biggest known (to me) plugin "fb-contrib" from Dave and found only one BC issue left - https://github.com/mebigfatguy/fb-contrib/issues/116.
This was also caused by some refactorings in not released code (ParameterAnnotationEntry).
So from my limited FindBugs point of view we can release BCEL6 as it is today on trunk.
BTW, if you will, you can compare current BCEL 6 jar from trunk with the latest "FB BCEL patch" jar here: https://github.com/findbugsproject/findbugs/blob/master/findbugs/lib/bcel-6.0-SNAPSHOT.jar. I think Clirr should be able to do a diff here. Don't ask me from which revision this patched jar was created, I have no clue.
This is the BCEL API state we "exported" to downstream since 3 years :-(
Kind regards,
Andrey Loskutov
http://google.com/+AndreyLoskutov
> Gesendet: Sonntag, 12. Juni 2016 um 14:12 Uhr
> Von: sebb <se...@gmail.com>
> An: "Commons Developers List" <de...@commons.apache.org>
> Betreff: Re: [BCEL] Latest Clirr report
>
> On 12 June 2016 at 12:43, Benedikt Ritter <br...@apache.org> wrote:
> > sebb <se...@gmail.com> schrieb am So., 12. Juni 2016 um 13:38 Uhr:
> >
> >> On 12 June 2016 at 12:00, Benedikt Ritter <br...@apache.org> wrote:
> >> > Hi,
> >> >
> >> > I've uploaded the verbose Clirr report to my space at home.apache.org
> >> [1].
> >> > Do we have to fix all of this in order to release 6.0?
> >>
> >> No, most of the changes don't break strict BC.
> >>
> >> The main changes to the interfaces don't break BC and are highly
> >> unlikely to affect source because there are abstract implementation
> >> classes.
> >>
> >> See the changes.xml file and release notes for some details.
> >>
> >
> > Thank you, I will have a look. Can we compile a list of things we need to
> > fix for 6.0?
>
> Unfortunately the lack of updates has caused downstream users to rely
> on non-released code.
> I think we should try and ensure that we don't make things worse.
>
> Therefore I don't think we can compile a full list without assistance
> from FindBugs and other consumers of the code.
>
> I suspect this will be an iterative process to try and find the best
> compromise that suits these users as well as users who have only used
> formal releases.
>
> > Benedikt
> >
> >
> >>
> >> > Benedikt
> >> >
> >> > [1]
> >> >
> >> http://home.apache.org/~britter/commons/bcel/6.0-SNAPSHOT/clirr-report.html
> >> >
> >> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:54 Uhr:
> >> >
> >> >> On 8 June 2016 at 10:46, Benedikt Ritter <br...@apache.org> wrote:
> >> >> > Hello sebb,
> >> >> >
> >> >> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:21 Uhr:
> >> >> >
> >> >> >> Was that the full report, or the 'quietened' one?
> >> >> >> There's a Clirr suppression file which removes some diffs that are
> >> >> >> considered non-breaking (as per the changes description)
> >> >> >> (otherwise the report is rather difficult to read)
> >> >> >>
> >> >> >> To show all the errors, use -P!quieten-clirr or
> >> -Dclirr.allDifferences
> >> >> >>
> >> >> >
> >> >> > The report is the result of running mvn clean site. So if
> >> quiten-clirr is
> >> >> > activated by default it's the 'quitened' one (sorry I currently don't
> >> >> have
> >> >> > time to look into the pom).
> >> >>
> >> >> Yes, it is the default.
> >> >>
> >> >> > I can upload the "real" report to home.apache.org tonight when I'm at
> >> >> home.
> >> >>
> >> >> OK, thanks.
> >> >>
> >> >> > Benedikt
> >> >> >
> >> >> >
> >> >> >>
> >> >> >> On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org> wrote:
> >> >> >> > Hi all,
> >> >> >> >
> >> >> >> > I've published the BCEL website after reverting the package rename.
> >> >> Here
> >> >> >> > [1] is the Clirr report of the current code base.
> >> >> >> >
> >> >> >> > Benedikt
> >> >> >> >
> >> >> >> > [1]
> >> http://commons.apache.org/proper/commons-bcel/clirr-report.html
> >> >> >>
> >> >> >> ---------------------------------------------------------------------
> >> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> >> >> For additional commands, e-mail: dev-help@commons.apache.org
> >> >> >>
> >> >> >>
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> >> For additional commands, e-mail: dev-help@commons.apache.org
> >> >>
> >> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [BCEL] Latest Clirr report
Posted by sebb <se...@gmail.com>.
On 12 June 2016 at 12:43, Benedikt Ritter <br...@apache.org> wrote:
> sebb <se...@gmail.com> schrieb am So., 12. Juni 2016 um 13:38 Uhr:
>
>> On 12 June 2016 at 12:00, Benedikt Ritter <br...@apache.org> wrote:
>> > Hi,
>> >
>> > I've uploaded the verbose Clirr report to my space at home.apache.org
>> [1].
>> > Do we have to fix all of this in order to release 6.0?
>>
>> No, most of the changes don't break strict BC.
>>
>> The main changes to the interfaces don't break BC and are highly
>> unlikely to affect source because there are abstract implementation
>> classes.
>>
>> See the changes.xml file and release notes for some details.
>>
>
> Thank you, I will have a look. Can we compile a list of things we need to
> fix for 6.0?
Unfortunately the lack of updates has caused downstream users to rely
on non-released code.
I think we should try and ensure that we don't make things worse.
Therefore I don't think we can compile a full list without assistance
from FindBugs and other consumers of the code.
I suspect this will be an iterative process to try and find the best
compromise that suits these users as well as users who have only used
formal releases.
> Benedikt
>
>
>>
>> > Benedikt
>> >
>> > [1]
>> >
>> http://home.apache.org/~britter/commons/bcel/6.0-SNAPSHOT/clirr-report.html
>> >
>> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:54 Uhr:
>> >
>> >> On 8 June 2016 at 10:46, Benedikt Ritter <br...@apache.org> wrote:
>> >> > Hello sebb,
>> >> >
>> >> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:21 Uhr:
>> >> >
>> >> >> Was that the full report, or the 'quietened' one?
>> >> >> There's a Clirr suppression file which removes some diffs that are
>> >> >> considered non-breaking (as per the changes description)
>> >> >> (otherwise the report is rather difficult to read)
>> >> >>
>> >> >> To show all the errors, use -P!quieten-clirr or
>> -Dclirr.allDifferences
>> >> >>
>> >> >
>> >> > The report is the result of running mvn clean site. So if
>> quiten-clirr is
>> >> > activated by default it's the 'quitened' one (sorry I currently don't
>> >> have
>> >> > time to look into the pom).
>> >>
>> >> Yes, it is the default.
>> >>
>> >> > I can upload the "real" report to home.apache.org tonight when I'm at
>> >> home.
>> >>
>> >> OK, thanks.
>> >>
>> >> > Benedikt
>> >> >
>> >> >
>> >> >>
>> >> >> On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org> wrote:
>> >> >> > Hi all,
>> >> >> >
>> >> >> > I've published the BCEL website after reverting the package rename.
>> >> Here
>> >> >> > [1] is the Clirr report of the current code base.
>> >> >> >
>> >> >> > Benedikt
>> >> >> >
>> >> >> > [1]
>> http://commons.apache.org/proper/commons-bcel/clirr-report.html
>> >> >>
>> >> >> ---------------------------------------------------------------------
>> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >> >>
>> >> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [BCEL] Latest Clirr report
Posted by Benedikt Ritter <br...@apache.org>.
sebb <se...@gmail.com> schrieb am So., 12. Juni 2016 um 13:38 Uhr:
> On 12 June 2016 at 12:00, Benedikt Ritter <br...@apache.org> wrote:
> > Hi,
> >
> > I've uploaded the verbose Clirr report to my space at home.apache.org
> [1].
> > Do we have to fix all of this in order to release 6.0?
>
> No, most of the changes don't break strict BC.
>
> The main changes to the interfaces don't break BC and are highly
> unlikely to affect source because there are abstract implementation
> classes.
>
> See the changes.xml file and release notes for some details.
>
Thank you, I will have a look. Can we compile a list of things we need to
fix for 6.0?
Benedikt
>
> > Benedikt
> >
> > [1]
> >
> http://home.apache.org/~britter/commons/bcel/6.0-SNAPSHOT/clirr-report.html
> >
> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:54 Uhr:
> >
> >> On 8 June 2016 at 10:46, Benedikt Ritter <br...@apache.org> wrote:
> >> > Hello sebb,
> >> >
> >> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:21 Uhr:
> >> >
> >> >> Was that the full report, or the 'quietened' one?
> >> >> There's a Clirr suppression file which removes some diffs that are
> >> >> considered non-breaking (as per the changes description)
> >> >> (otherwise the report is rather difficult to read)
> >> >>
> >> >> To show all the errors, use -P!quieten-clirr or
> -Dclirr.allDifferences
> >> >>
> >> >
> >> > The report is the result of running mvn clean site. So if
> quiten-clirr is
> >> > activated by default it's the 'quitened' one (sorry I currently don't
> >> have
> >> > time to look into the pom).
> >>
> >> Yes, it is the default.
> >>
> >> > I can upload the "real" report to home.apache.org tonight when I'm at
> >> home.
> >>
> >> OK, thanks.
> >>
> >> > Benedikt
> >> >
> >> >
> >> >>
> >> >> On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org> wrote:
> >> >> > Hi all,
> >> >> >
> >> >> > I've published the BCEL website after reverting the package rename.
> >> Here
> >> >> > [1] is the Clirr report of the current code base.
> >> >> >
> >> >> > Benedikt
> >> >> >
> >> >> > [1]
> http://commons.apache.org/proper/commons-bcel/clirr-report.html
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> >> For additional commands, e-mail: dev-help@commons.apache.org
> >> >>
> >> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [BCEL] Latest Clirr report
Posted by sebb <se...@gmail.com>.
On 12 June 2016 at 12:00, Benedikt Ritter <br...@apache.org> wrote:
> Hi,
>
> I've uploaded the verbose Clirr report to my space at home.apache.org [1].
> Do we have to fix all of this in order to release 6.0?
No, most of the changes don't break strict BC.
The main changes to the interfaces don't break BC and are highly
unlikely to affect source because there are abstract implementation
classes.
See the changes.xml file and release notes for some details.
> Benedikt
>
> [1]
> http://home.apache.org/~britter/commons/bcel/6.0-SNAPSHOT/clirr-report.html
>
> sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:54 Uhr:
>
>> On 8 June 2016 at 10:46, Benedikt Ritter <br...@apache.org> wrote:
>> > Hello sebb,
>> >
>> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:21 Uhr:
>> >
>> >> Was that the full report, or the 'quietened' one?
>> >> There's a Clirr suppression file which removes some diffs that are
>> >> considered non-breaking (as per the changes description)
>> >> (otherwise the report is rather difficult to read)
>> >>
>> >> To show all the errors, use -P!quieten-clirr or -Dclirr.allDifferences
>> >>
>> >
>> > The report is the result of running mvn clean site. So if quiten-clirr is
>> > activated by default it's the 'quitened' one (sorry I currently don't
>> have
>> > time to look into the pom).
>>
>> Yes, it is the default.
>>
>> > I can upload the "real" report to home.apache.org tonight when I'm at
>> home.
>>
>> OK, thanks.
>>
>> > Benedikt
>> >
>> >
>> >>
>> >> On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org> wrote:
>> >> > Hi all,
>> >> >
>> >> > I've published the BCEL website after reverting the package rename.
>> Here
>> >> > [1] is the Clirr report of the current code base.
>> >> >
>> >> > Benedikt
>> >> >
>> >> > [1] http://commons.apache.org/proper/commons-bcel/clirr-report.html
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [BCEL] Latest Clirr report
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Mon, Jun 13, 2016 at 12:03 AM, sebb <se...@gmail.com> wrote:
>> I'd suggest to leave the java.io.Serializable stuff, as it is. In
>> practice, this will only be noticed, if anyone is actually
>> serializing/deserializing these items, and I assume that the interface
>> has been removed for a reason. (Meaning: Although the interface
>> declaration is present, they most likely aren't actually
>> serializable.)
>
> I don't follow what you are suggesting.
> Serializable has been removed from everything, as it does not make
> sense to serialise BCEl and anyway was not supported properly.
> Are you suggesting implements Serializable should be restored?
No, I propose to leave it, as it is now, and ignore this in the clirr report.
Although removing the interface java.io.Serializable does formally constitute
a binary incompatibiliy, this is unlikely to constitute a problem. And
those, who
will notice, will typically notice at runtime anyways, because these
classes are declared Serializable, although they aren't really.
Jochen
--
The next time you hear: "Don't reinvent the wheel!"
http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [BCEL] Latest Clirr report
Posted by sebb <se...@gmail.com>.
On 12 June 2016 at 15:21, Jochen Wiedmann <jo...@gmail.com> wrote:
> On Sun, Jun 12, 2016 at 1:00 PM, Benedikt Ritter <br...@apache.org> wrote:
>
>> I've uploaded the verbose Clirr report to my space at home.apache.org [1].
>> Do we have to fix all of this in order to release 6.0?
>
>
> I'd suggest to leave the java.io.Serializable stuff, as it is. In
> practice, this will only be noticed, if anyone is actually
> serializing/deserializing these items, and I assume that the interface
> has been removed for a reason. (Meaning: Although the interface
> declaration is present, they most likely aren't actually
> serializable.)
I don't follow what you are suggesting.
Serializable has been removed from everything, as it does not make
sense to serialise BCEl and anyway was not supported properly.
Are you suggesting implements Serializable should be restored?
> Jochen
>
>
> --
> The next time you hear: "Don't reinvent the wheel!"
>
> http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [BCEL] Latest Clirr report
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Sun, Jun 12, 2016 at 1:00 PM, Benedikt Ritter <br...@apache.org> wrote:
> I've uploaded the verbose Clirr report to my space at home.apache.org [1].
> Do we have to fix all of this in order to release 6.0?
I'd suggest to leave the java.io.Serializable stuff, as it is. In
practice, this will only be noticed, if anyone is actually
serializing/deserializing these items, and I assume that the interface
has been removed for a reason. (Meaning: Although the interface
declaration is present, they most likely aren't actually
serializable.)
Jochen
--
The next time you hear: "Don't reinvent the wheel!"
http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [BCEL] Latest Clirr report
Posted by Benedikt Ritter <br...@apache.org>.
Hi,
I've uploaded the verbose Clirr report to my space at home.apache.org [1].
Do we have to fix all of this in order to release 6.0?
Benedikt
[1]
http://home.apache.org/~britter/commons/bcel/6.0-SNAPSHOT/clirr-report.html
sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:54 Uhr:
> On 8 June 2016 at 10:46, Benedikt Ritter <br...@apache.org> wrote:
> > Hello sebb,
> >
> > sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:21 Uhr:
> >
> >> Was that the full report, or the 'quietened' one?
> >> There's a Clirr suppression file which removes some diffs that are
> >> considered non-breaking (as per the changes description)
> >> (otherwise the report is rather difficult to read)
> >>
> >> To show all the errors, use -P!quieten-clirr or -Dclirr.allDifferences
> >>
> >
> > The report is the result of running mvn clean site. So if quiten-clirr is
> > activated by default it's the 'quitened' one (sorry I currently don't
> have
> > time to look into the pom).
>
> Yes, it is the default.
>
> > I can upload the "real" report to home.apache.org tonight when I'm at
> home.
>
> OK, thanks.
>
> > Benedikt
> >
> >
> >>
> >> On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org> wrote:
> >> > Hi all,
> >> >
> >> > I've published the BCEL website after reverting the package rename.
> Here
> >> > [1] is the Clirr report of the current code base.
> >> >
> >> > Benedikt
> >> >
> >> > [1] http://commons.apache.org/proper/commons-bcel/clirr-report.html
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [BCEL] Latest Clirr report
Posted by sebb <se...@gmail.com>.
On 8 June 2016 at 10:46, Benedikt Ritter <br...@apache.org> wrote:
> Hello sebb,
>
> sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:21 Uhr:
>
>> Was that the full report, or the 'quietened' one?
>> There's a Clirr suppression file which removes some diffs that are
>> considered non-breaking (as per the changes description)
>> (otherwise the report is rather difficult to read)
>>
>> To show all the errors, use -P!quieten-clirr or -Dclirr.allDifferences
>>
>
> The report is the result of running mvn clean site. So if quiten-clirr is
> activated by default it's the 'quitened' one (sorry I currently don't have
> time to look into the pom).
Yes, it is the default.
> I can upload the "real" report to home.apache.org tonight when I'm at home.
OK, thanks.
> Benedikt
>
>
>>
>> On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org> wrote:
>> > Hi all,
>> >
>> > I've published the BCEL website after reverting the package rename. Here
>> > [1] is the Clirr report of the current code base.
>> >
>> > Benedikt
>> >
>> > [1] http://commons.apache.org/proper/commons-bcel/clirr-report.html
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [BCEL] Latest Clirr report
Posted by Benedikt Ritter <br...@apache.org>.
Hello sebb,
sebb <se...@gmail.com> schrieb am Mi., 8. Juni 2016 um 11:21 Uhr:
> Was that the full report, or the 'quietened' one?
> There's a Clirr suppression file which removes some diffs that are
> considered non-breaking (as per the changes description)
> (otherwise the report is rather difficult to read)
>
> To show all the errors, use -P!quieten-clirr or -Dclirr.allDifferences
>
The report is the result of running mvn clean site. So if quiten-clirr is
activated by default it's the 'quitened' one (sorry I currently don't have
time to look into the pom).
I can upload the "real" report to home.apache.org tonight when I'm at home.
Benedikt
>
> On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org> wrote:
> > Hi all,
> >
> > I've published the BCEL website after reverting the package rename. Here
> > [1] is the Clirr report of the current code base.
> >
> > Benedikt
> >
> > [1] http://commons.apache.org/proper/commons-bcel/clirr-report.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [BCEL] Latest Clirr report
Posted by sebb <se...@gmail.com>.
Was that the full report, or the 'quietened' one?
There's a Clirr suppression file which removes some diffs that are
considered non-breaking (as per the changes description)
(otherwise the report is rather difficult to read)
To show all the errors, use -P!quieten-clirr or -Dclirr.allDifferences
On 8 June 2016 at 09:35, Benedikt Ritter <br...@apache.org> wrote:
> Hi all,
>
> I've published the BCEL website after reverting the package rename. Here
> [1] is the Clirr report of the current code base.
>
> Benedikt
>
> [1] http://commons.apache.org/proper/commons-bcel/clirr-report.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org