You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/08/09 10:35:00 UTC
[jira] [Commented] (AIRFLOW-4230) bigquery schema update options
should be a list
[ https://issues.apache.org/jira/browse/AIRFLOW-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903797#comment-16903797 ]
ASF GitHub Bot commented on AIRFLOW-4230:
-----------------------------------------
nuclearpinguin commented on pull request #5766: [AIRFLOW-4230] BigQuery schema update options should be a list
URL: https://github.com/apache/airflow/pull/5766
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-4230
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> bigquery schema update options should be a list
> -----------------------------------------------
>
> Key: AIRFLOW-4230
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4230
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib, gcp, hooks, operators
> Reporter: Ben Marengo
> Assignee: Tomasz Urbaszek
> Priority: Minor
>
> in AIRFLOW-1829 schema update options were implemented as a tuple, which doesn't make any sense
> - this is inconsistent with the [bq api|https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs], which expects a list
> - and doesnt allow the user of operators to deserialise config json (which doesnt support tuples) to a dict and use them as the args for the bq operator
> eg. i would like to be able to do the following without having to cast schema_update_options as a tuple:
> {code}
> config_dict = json.loads(some_config)
> BigQueryOperator(**config_dict)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)