You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2023/01/04 07:25:16 UTC

[GitHub] [apisix] xiaoxuanzi commented on a diff in pull request #8604: feat(elasticsearch-logger): support multi elasticsearch endpoints(#8431)

xiaoxuanzi commented on code in PR #8604:
URL: https://github.com/apache/apisix/pull/8604#discussion_r1061194533


##########
apisix/plugins/elasticsearch-logger.lua:
##########
@@ -31,10 +32,19 @@ local batch_processor_manager = bp_manager_mod.new(plugin_name)
 local schema = {
     type = "object",
     properties = {
+        -- deprecated, use "endpoint_addrs" instead
         endpoint_addr = {
             type = "string",
             pattern = "[^/]$",
         },
+        endpoint_addrs = {

Review Comment:
   Thank you for your reply.
   
   What is your suggestion?
   Can you give an example?
   I refer to PR #7517
   
   > feat(clickhouse-logger): support multi clickhouse endpoints



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org