You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/12/12 19:07:27 UTC
[kudu-CR] KUDU-1805: Properly qualify classes in generated svc headers
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5478
Change subject: KUDU-1805: Properly qualify classes in generated svc headers
......................................................................
KUDU-1805: Properly qualify classes in generated svc headers
Change-Id: Id67c60477133699959c0e1004e69871e20657fc9
---
M src/kudu/rpc/protoc-gen-krpc.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/5478/1
--
To view, visit http://gerrit.cloudera.org:8080/5478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id67c60477133699959c0e1004e69871e20657fc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[kudu-CR] KUDU-1805: Properly qualify classes in generated svc headers
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1805: Properly qualify classes in generated svc headers
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id67c60477133699959c0e1004e69871e20657fc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1805: Properly qualify classes in generated svc headers
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-1805: Properly qualify classes in generated svc headers
......................................................................
KUDU-1805: Properly qualify classes in generated svc headers
Change-Id: Id67c60477133699959c0e1004e69871e20657fc9
Reviewed-on: http://gerrit.cloudera.org:8080/5478
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/rpc/protoc-gen-krpc.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id67c60477133699959c0e1004e69871e20657fc9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins