You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/12/07 22:00:13 UTC
[GitHub] [daffodil-site] Shanedell opened a new pull request, #101: Update VS Code 1.2.0 summary
Shanedell opened a new pull request, #101:
URL: https://github.com/apache/daffodil-site/pull/101
Quick fix to make the 1.2.0 summary not be the same as 1.1.0's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence commented on a diff in pull request #101: Update VS Code 1.2.0 summary
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #101:
URL: https://github.com/apache/daffodil-site/pull/101#discussion_r1043646110
##########
site/_vscode/1.2.0.md:
##########
@@ -5,7 +5,7 @@ apache: true
title: 1.2.0
date: 2022-12-06
summary: >
- Initial omega-edit client & DFDL language
+ Bug fixes and improvements
Review Comment:
I think in general we've just left if up to who ever opens the PR to determine the need for review and how much time to give review. It's nice to give time for other +1's, but they aren't mandatory for the site repo. And for small changes it's not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] Shanedell commented on a diff in pull request #101: Update VS Code 1.2.0 summary
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #101:
URL: https://github.com/apache/daffodil-site/pull/101#discussion_r1042751441
##########
site/_vscode/1.2.0.md:
##########
@@ -5,7 +5,7 @@ apache: true
title: 1.2.0
date: 2022-12-06
summary: >
- Initial omega-edit client & DFDL language
+ Bug fixes and improvements
Review Comment:
@stevedlawrence would something like:
```text
Testing, omega-edit, intellisense, configuration and debugging improvements. Along with package upgrades and bug fixes.
```
be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence commented on a diff in pull request #101: Update VS Code 1.2.0 summary
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #101:
URL: https://github.com/apache/daffodil-site/pull/101#discussion_r1043583953
##########
site/_vscode/1.2.0.md:
##########
@@ -5,7 +5,7 @@ apache: true
title: 1.2.0
date: 2022-12-06
summary: >
- Initial omega-edit client & DFDL language
+ Bug fixes and improvements
Review Comment:
Sounds fine. Note you also don't need two +1's to merge to the site repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence commented on a diff in pull request #101: Update VS Code 1.2.0 summary
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #101:
URL: https://github.com/apache/daffodil-site/pull/101#discussion_r1042745415
##########
site/_vscode/1.2.0.md:
##########
@@ -5,7 +5,7 @@ apache: true
title: 1.2.0
date: 2022-12-06
summary: >
- Initial omega-edit client & DFDL language
+ Bug fixes and improvements
Review Comment:
Is there anything more specific than this? This could describe any release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] Shanedell commented on a diff in pull request #101: Update VS Code 1.2.0 summary
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #101:
URL: https://github.com/apache/daffodil-site/pull/101#discussion_r1043641397
##########
site/_vscode/1.2.0.md:
##########
@@ -5,7 +5,7 @@ apache: true
title: 1.2.0
date: 2022-12-06
summary: >
- Initial omega-edit client & DFDL language
+ Bug fixes and improvements
Review Comment:
@stevedlawrence Oh I assumed it was the same as the other repos, is it just one +1 for this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] Shanedell commented on a diff in pull request #101: Update VS Code 1.2.0 summary
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #101:
URL: https://github.com/apache/daffodil-site/pull/101#discussion_r1042751441
##########
site/_vscode/1.2.0.md:
##########
@@ -5,7 +5,7 @@ apache: true
title: 1.2.0
date: 2022-12-06
summary: >
- Initial omega-edit client & DFDL language
+ Bug fixes and improvements
Review Comment:
@stevedlawrence would something like:
```text
Testing, omega-edit, intellisense, configuration and debugging improvements. Along
with package upgrades and bug fixes.
```
be better?
##########
site/_vscode/1.2.0.md:
##########
@@ -5,7 +5,7 @@ apache: true
title: 1.2.0
date: 2022-12-06
summary: >
- Initial omega-edit client & DFDL language
+ Bug fixes and improvements
Review Comment:
@stevedlawrence would something like:
```text
Testing, omega-edit, intellisense, configuration and debugging
improvements. Along with package upgrades and bug fixes.
```
be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] Shanedell merged pull request #101: Update VS Code 1.2.0 summary
Posted by GitBox <gi...@apache.org>.
Shanedell merged PR #101:
URL: https://github.com/apache/daffodil-site/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org