You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/06 07:22:42 UTC
[GitHub] [pulsar] boatrainlsz opened a new pull request, #15947: [fix][python client] Fixed reserved keys is not removed when JsonSchema being encoded
boatrainlsz opened a new pull request, #15947:
URL: https://github.com/apache/pulsar/pull/15947
Fixes #15844
### Motivation
JsonSchema doesn't remove reserved keys(`_default`,`_required`,`_required_default`) when being encoded. Resulting in confusing encoding output.
### Modifications
Extract a common method to remove reserved keys when JsonSchema is being encoded, and this common method will be called when JsonSchema::encode method is called.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- *Added a unit test method named test_json_schema_encode_remove_reserved_key, see pulsar-client-cpp/python/schema_test.py*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / **no**)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] boatrainlsz commented on pull request #15947: [fix][python client] Fixed reserved keys is not removed when JsonSchema being encoded
Posted by GitBox <gi...@apache.org>.
boatrainlsz commented on PR #15947:
URL: https://github.com/apache/pulsar/pull/15947#issuecomment-1148199375
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] boatrainlsz closed pull request #15947: [fix][python client] Fixed reserved keys is not removed when JsonSchema being encoded
Posted by GitBox <gi...@apache.org>.
boatrainlsz closed pull request #15947: [fix][python client] Fixed reserved keys is not removed when JsonSchema being encoded
URL: https://github.com/apache/pulsar/pull/15947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] boatrainlsz commented on pull request #15947: [fix][python client] Fixed reserved keys is not removed when JsonSchema being encoded
Posted by GitBox <gi...@apache.org>.
boatrainlsz commented on PR #15947:
URL: https://github.com/apache/pulsar/pull/15947#issuecomment-1148094101
> > The change looks good. Please remove the unintended changes to the config files.
>
> Sorry for that, I will remove those unintended changes later
@merlimat I've removed those changes, please kindly review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #15947: [fix][python client] Fixed reserved keys is not removed when JsonSchema being encoded
Posted by GitBox <gi...@apache.org>.
merlimat merged PR #15947:
URL: https://github.com/apache/pulsar/pull/15947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] boatrainlsz commented on pull request #15947: [fix][python client] Fixed reserved keys is not removed when JsonSchema being encoded
Posted by GitBox <gi...@apache.org>.
boatrainlsz commented on PR #15947:
URL: https://github.com/apache/pulsar/pull/15947#issuecomment-1148040847
> The change looks good. Please remove the unintended changes to the config files.
Sorry for that, I will remove those unintended changes later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15947: [fix][python client] Fixed reserved keys is not removed when JsonSchema being encoded
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15947:
URL: https://github.com/apache/pulsar/pull/15947#issuecomment-1147133494
@boatrainlsz:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org