You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/06 09:10:35 UTC
[GitHub] [shardingsphere-elasticjob] stanstanwang opened a new pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
stanstanwang opened a new pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956
Bugfix: getJobConfiguration return null instead of throw NullPointerException
Changes proposed in this pull request:
- check the zk result before `YamlEngine.unmarshal`
Before that, getting the JobConfiguration was more troublesome
``` java
JobConfigurationPOJO jobConfiguration = null;
try {
jobConfiguration = jobConfigurationAPI.getJobConfiguration(jobKey);
} catch (NullPointerException e) {
// ignore
}
// do something
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f6377d) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/aac91a38c09037e14a7e761307ec39dda970cdf4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac91a3) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1956 +/- ##
============================================
- Coverage 85.75% 85.72% -0.04%
Complexity 138 138
============================================
Files 277 277
Lines 6038 6052 +14
Branches 917 921 +4
============================================
+ Hits 5178 5188 +10
- Misses 525 527 +2
- Partials 335 337 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../lite/internal/schedule/JobScheduleController.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvSm9iU2NoZWR1bGVDb250cm9sbGVyLmphdmE=) | `87.30% <0.00%> (-3.93%)` | :arrow_down: |
| [...hardingsphere/elasticjob/api/JobConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvYXBpL0pvYkNvbmZpZ3VyYXRpb24uamF2YQ==) | `73.07% <0.00%> (-0.40%)` | :arrow_down: |
| [...re/elasticjob/infra/pojo/JobConfigurationPOJO.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9wb2pvL0pvYkNvbmZpZ3VyYXRpb25QT0pPLmphdmE=) | `100.00% <0.00%> (ø)` | |
| [.../namespace/job/parser/JobBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL2pvYi9wYXJzZXIvSm9iQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...ng/boot/job/ElasticJobConfigurationProperties.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvYm9vdC9qb2IvRWxhc3RpY0pvYkNvbmZpZ3VyYXRpb25Qcm9wZXJ0aWVzLmphdmE=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aac91a3...6f6377d](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] stanstanwang commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
stanstanwang commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894582598
> Hi @stanstanwang
> I think returning null is not elegant. How about throw something like `JobConfigurationException`?
in my usage scenario , there is no check config exists method, so every time before i get the config, i must catch the NullPointerException , this is troublesome, may be mark the method return @Nullable or using Optional is also elegant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-895702225
> Returning `null` is violate our code of conduct. I think `Optional` may be better.
Where do this conflict? If conflict, we should also refactor ZookeeperRegistryCenter. Not this API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#discussion_r684321410
##########
File path: elasticjob-lite/elasticjob-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImpl.java
##########
@@ -31,22 +31,26 @@
*/
@RequiredArgsConstructor
public final class JobConfigurationAPIImpl implements JobConfigurationAPI {
-
+
Review comment:
BTW, keep the indents please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-895699792
Returning `null` is violate our code of conduct. I think `Optional` may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on a change in pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#discussion_r685719038
##########
File path: elasticjob-lite/elasticjob-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImpl.java
##########
@@ -36,7 +36,11 @@
@Override
public JobConfigurationPOJO getJobConfiguration(final String jobName) {
- return YamlEngine.unmarshal(regCenter.get(new JobNodePath(jobName).getConfigNodePath()), JobConfigurationPOJO.class);
+ String yamlContent = regCenter.get(new JobNodePath(jobName).getConfigNodePath());
Review comment:
How about like this:
Optional.ofNullable(yamlContent).map(v -> YamlEngine.unmarshal(v, JobConfigurationPOJO.class)).orElse(null) ?
@TeslaCN @stanstanwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b00b3fe) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/1b2b15d7bf653b1fd6d455d940eabb13793347bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b2b15d) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1956 +/- ##
============================================
+ Coverage 85.56% 85.61% +0.05%
- Complexity 113 137 +24
============================================
Files 276 277 +1
Lines 6026 6041 +15
Branches 922 918 -4
============================================
+ Hits 5156 5172 +16
- Misses 530 531 +1
+ Partials 340 338 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ticjob/lite/internal/instance/InstanceService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvaW5zdGFuY2UvSW5zdGFuY2VTZXJ2aWNlLmphdmE=) | `95.23% <0.00%> (-4.77%)` | :arrow_down: |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-3.18%)` | :arrow_down: |
| [.../lifecycle/internal/operate/JobOperateAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvb3BlcmF0ZS9Kb2JPcGVyYXRlQVBJSW1wbC5qYXZh) | `91.78% <0.00%> (-0.33%)` | :arrow_down: |
| [...rdingsphere/elasticjob/infra/json/GsonFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9qc29uL0dzb25GYWN0b3J5LmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...asticjob/lite/internal/schedule/LiteJobFacade.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvTGl0ZUpvYkZhY2FkZS5qYXZh) | `96.29% <0.00%> (ø)` | |
| [...gsphere/elasticjob/tracing/JobTracingEventBus.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9Kb2JUcmFjaW5nRXZlbnRCdXMuamF2YQ==) | `95.65% <0.00%> (ø)` | |
| [...mespace/setup/SpringProxyJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL3NldHVwL1NwcmluZ1Byb3h5Sm9iQ2xhc3NOYW1lUHJvdmlkZXIuamF2YQ==) | | |
| [...lite/spring/namespace/job/util/AopTargetUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL2pvYi91dGlsL0FvcFRhcmdldFV0aWxzLmphdmE=) | | |
| [...ng/core/setup/SpringProxyJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvc3ByaW5nL2NvcmUvc2V0dXAvU3ByaW5nUHJveHlKb2JDbGFzc05hbWVQcm92aWRlci5qYXZh) | `80.00% <0.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b2b15d...b00b3fe](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f6377d) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/aac91a38c09037e14a7e761307ec39dda970cdf4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac91a3) will **decrease** coverage by `0.14%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1956 +/- ##
============================================
- Coverage 85.75% 85.60% -0.15%
+ Complexity 138 136 -2
============================================
Files 277 277
Lines 6038 6052 +14
Branches 917 921 +4
============================================
+ Hits 5178 5181 +3
- Misses 525 529 +4
- Partials 335 342 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../datasource/DataSourceTracingStorageConverter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvZGF0YXNvdXJjZS9EYXRhU291cmNlVHJhY2luZ1N0b3JhZ2VDb252ZXJ0ZXIuamF2YQ==) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| [.../lite/internal/schedule/JobScheduleController.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvSm9iU2NoZWR1bGVDb250cm9sbGVyLmphdmE=) | `87.30% <0.00%> (-3.93%)` | :arrow_down: |
| [...ob/error/handler/wechat/WechatJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci13ZWNoYXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvZXJyb3IvaGFuZGxlci93ZWNoYXQvV2VjaGF0Sm9iRXJyb3JIYW5kbGVyLmphdmE=) | `89.47% <0.00%> (-2.64%)` | :arrow_down: |
| [...rror/handler/dingtalk/DingtalkJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1kaW5ndGFsay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2Rpbmd0YWxrL0Rpbmd0YWxrSm9iRXJyb3JIYW5kbGVyLmphdmE=) | `88.46% <0.00%> (-1.93%)` | :arrow_down: |
| [...asticjob/lite/internal/storage/JobNodeStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlU3RvcmFnZS5qYXZh) | `91.07% <0.00%> (-1.79%)` | :arrow_down: |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `65.71% <0.00%> (-1.43%)` | :arrow_down: |
| [...b/cloud/console/controller/CloudJobController.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL2NvbnRyb2xsZXIvQ2xvdWRKb2JDb250cm9sbGVyLmphdmE=) | `68.31% <0.00%> (-1.00%)` | :arrow_down: |
| [...ticjob/tracing/rdb/storage/RDBJobEventStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvc3RvcmFnZS9SREJKb2JFdmVudFN0b3JhZ2UuamF2YQ==) | `81.39% <0.00%> (-0.47%)` | :arrow_down: |
| [...hardingsphere/elasticjob/api/JobConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvYXBpL0pvYkNvbmZpZ3VyYXRpb24uamF2YQ==) | `73.07% <0.00%> (-0.40%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aac91a3...6f6377d](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] stanstanwang commented on a change in pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
stanstanwang commented on a change in pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#discussion_r684562218
##########
File path: elasticjob-lite/elasticjob-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImpl.java
##########
@@ -31,22 +31,26 @@
*/
@RequiredArgsConstructor
public final class JobConfigurationAPIImpl implements JobConfigurationAPI {
-
+
Review comment:
fixed，sorry but there is a litte strange why 4 space indent in every empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#discussion_r685707779
##########
File path: elasticjob-lite/elasticjob-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImpl.java
##########
@@ -36,7 +36,11 @@
@Override
public JobConfigurationPOJO getJobConfiguration(final String jobName) {
- return YamlEngine.unmarshal(regCenter.get(new JobNodePath(jobName).getConfigNodePath()), JobConfigurationPOJO.class);
+ String yamlContent = regCenter.get(new JobNodePath(jobName).getConfigNodePath());
+ if (yamlContent == null) {
Review comment:
Constant is on the left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-895707160
> > Returning `null` is violate our code of conduct. I think `Optional` may be better.
>
> Where do this conflict? If conflict, we should also refactor ZookeeperRegistryCenter. Not this API.
This API is used by user directly. Maybe the `ZookeeperRegistryCenter` does need to be refactored but not in this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9259be7) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/aac91a38c09037e14a7e761307ec39dda970cdf4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac91a3) will **decrease** coverage by `0.16%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 9259be7 differs from pull request most recent head 6f6377d. Consider uploading reports for the commit 6f6377d to get more accurate results
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1956 +/- ##
============================================
- Coverage 85.75% 85.59% -0.17%
+ Complexity 138 137 -1
============================================
Files 277 277
Lines 6038 6052 +14
Branches 917 921 +4
============================================
+ Hits 5178 5180 +2
- Misses 525 528 +3
- Partials 335 344 +9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../lite/internal/schedule/JobScheduleController.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvSm9iU2NoZWR1bGVDb250cm9sbGVyLmphdmE=) | `87.30% <66.66%> (-3.93%)` | :arrow_down: |
| [...hardingsphere/elasticjob/api/JobConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvYXBpL0pvYkNvbmZpZ3VyYXRpb24uamF2YQ==) | `73.07% <75.00%> (-0.40%)` | :arrow_down: |
| [...re/elasticjob/infra/pojo/JobConfigurationPOJO.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9wb2pvL0pvYkNvbmZpZ3VyYXRpb25QT0pPLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../lite/api/bootstrap/impl/ScheduleJobBootstrap.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL2Jvb3RzdHJhcC9pbXBsL1NjaGVkdWxlSm9iQm9vdHN0cmFwLmphdmE=) | `63.63% <100.00%> (ø)` | |
| [...ite/internal/config/RescheduleListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvY29uZmlnL1Jlc2NoZWR1bGVMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `85.71% <100.00%> (ø)` | |
| [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ng/boot/job/ElasticJobConfigurationProperties.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvYm9vdC9qb2IvRWxhc3RpY0pvYkNvbmZpZ3VyYXRpb25Qcm9wZXJ0aWVzLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../namespace/job/parser/JobBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL2pvYi9wYXJzZXIvSm9iQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../datasource/DataSourceTracingStorageConverter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvZGF0YXNvdXJjZS9EYXRhU291cmNlVHJhY2luZ1N0b3JhZ2VDb252ZXJ0ZXIuamF2YQ==) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| [...re/elasticjob/lite/internal/setup/SetUpFacade.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2V0dXAvU2V0VXBGYWNhZGUuamF2YQ==) | `89.47% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aac91a3...6f6377d](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b00b3fe) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/1b2b15d7bf653b1fd6d455d940eabb13793347bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b2b15d) will **increase** coverage by `0.20%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1956 +/- ##
============================================
+ Coverage 85.56% 85.76% +0.20%
- Complexity 113 138 +25
============================================
Files 276 277 +1
Lines 6026 6041 +15
Branches 922 918 -4
============================================
+ Hits 5156 5181 +25
+ Misses 530 525 -5
+ Partials 340 335 -5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ticjob/lite/internal/instance/InstanceService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvaW5zdGFuY2UvSW5zdGFuY2VTZXJ2aWNlLmphdmE=) | `95.23% <0.00%> (-4.77%)` | :arrow_down: |
| [.../lifecycle/internal/operate/JobOperateAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvb3BlcmF0ZS9Kb2JPcGVyYXRlQVBJSW1wbC5qYXZh) | `91.78% <0.00%> (-0.33%)` | :arrow_down: |
| [...rdingsphere/elasticjob/infra/json/GsonFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9qc29uL0dzb25GYWN0b3J5LmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...asticjob/lite/internal/schedule/LiteJobFacade.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvTGl0ZUpvYkZhY2FkZS5qYXZh) | `96.29% <0.00%> (ø)` | |
| [...gsphere/elasticjob/tracing/JobTracingEventBus.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9Kb2JUcmFjaW5nRXZlbnRCdXMuamF2YQ==) | `95.65% <0.00%> (ø)` | |
| [...lite/spring/namespace/job/util/AopTargetUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL2pvYi91dGlsL0FvcFRhcmdldFV0aWxzLmphdmE=) | | |
| [...mespace/setup/SpringProxyJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL3NldHVwL1NwcmluZ1Byb3h5Sm9iQ2xhc3NOYW1lUHJvdmlkZXIuamF2YQ==) | | |
| [...ng/core/setup/SpringProxyJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvc3ByaW5nL2NvcmUvc2V0dXAvU3ByaW5nUHJveHlKb2JDbGFzc05hbWVQcm92aWRlci5qYXZh) | `80.00% <0.00%> (ø)` | |
| [...asticjob/lite/spring/core/util/AopTargetUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvc3ByaW5nL2NvcmUvdXRpbC9Bb3BUYXJnZXRVdGlscy5qYXZh) | `76.92% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b2b15d...b00b3fe](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-895712264
> > > Returning `null` is violate our code of conduct. I think `Optional` may be better.
> >
> >
> > Where do this conflict? If conflict, we should also refactor ZookeeperRegistryCenter. Not this API.
>
> This API is used by user directly. Maybe the `ZookeeperRegistryCenter` does need to be refactored but not in this issue.
If user upgrade to current version, compile error in they project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894338638
Code of conduct: https://shardingsphere.apache.org/community/en/contribute/code-conduct/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-895747100
> > > > Returning `null` is violate our code of conduct. I think `Optional` may be better.
> > >
> > >
> > > Where do this conflict? If conflict, we should also refactor ZookeeperRegistryCenter. Not this API.
> >
> >
> > This API is used by user directly. Maybe the `ZookeeperRegistryCenter` does need to be refactored but not in this issue.
>
> If user upgrade to current version, compile error in they project.
OK, we can keep the current API. But we should polish it in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-895648028
> > Hi @stanstanwang
> > I think returning null is not elegant. How about throw something like `JobConfigurationException`?
>
> in my usage scenario , there is no check config exists method, so every time before i get the config, i must catch the NullPointerException , this is troublesome, may be mark the method return @nullable or using Optional is also elegant
Currently, fit it that not throw NPE is enough. Other further discuss can open a new thread to discuss. @TeslaCN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] stanstanwang commented on a change in pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
stanstanwang commented on a change in pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#discussion_r685715507
##########
File path: elasticjob-lite/elasticjob-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImpl.java
##########
@@ -36,7 +36,11 @@
@Override
public JobConfigurationPOJO getJobConfiguration(final String jobName) {
- return YamlEngine.unmarshal(regCenter.get(new JobNodePath(jobName).getConfigNodePath()), JobConfigurationPOJO.class);
+ String yamlContent = regCenter.get(new JobNodePath(jobName).getConfigNodePath());
+ if (yamlContent == null) {
Review comment:
fixed, sorry for that..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddc47c9) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/aac91a38c09037e14a7e761307ec39dda970cdf4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac91a3) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1956 +/- ##
=========================================
Coverage 85.75% 85.76%
+ Complexity 138 137 -1
=========================================
Files 277 277
Lines 6038 6041 +3
Branches 917 918 +1
=========================================
+ Hits 5178 5181 +3
- Misses 525 526 +1
+ Partials 335 334 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `72.80% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aac91a3...ddc47c9](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b00b3fe) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/1b2b15d7bf653b1fd6d455d940eabb13793347bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b2b15d) will **increase** coverage by `0.20%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1956 +/- ##
============================================
+ Coverage 85.56% 85.76% +0.20%
- Complexity 113 138 +25
============================================
Files 276 277 +1
Lines 6026 6041 +15
Branches 922 918 -4
============================================
+ Hits 5156 5181 +25
+ Misses 530 526 -4
+ Partials 340 334 -6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ticjob/lite/internal/instance/InstanceService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvaW5zdGFuY2UvSW5zdGFuY2VTZXJ2aWNlLmphdmE=) | `95.23% <0.00%> (-4.77%)` | :arrow_down: |
| [.../lifecycle/internal/operate/JobOperateAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvb3BlcmF0ZS9Kb2JPcGVyYXRlQVBJSW1wbC5qYXZh) | `91.78% <0.00%> (-0.33%)` | :arrow_down: |
| [...rdingsphere/elasticjob/infra/json/GsonFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9qc29uL0dzb25GYWN0b3J5LmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...asticjob/lite/internal/schedule/LiteJobFacade.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvTGl0ZUpvYkZhY2FkZS5qYXZh) | `96.29% <0.00%> (ø)` | |
| [...gsphere/elasticjob/tracing/JobTracingEventBus.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9Kb2JUcmFjaW5nRXZlbnRCdXMuamF2YQ==) | `95.65% <0.00%> (ø)` | |
| [...lite/spring/namespace/job/util/AopTargetUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL2pvYi91dGlsL0FvcFRhcmdldFV0aWxzLmphdmE=) | | |
| [...mespace/setup/SpringProxyJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL3NldHVwL1NwcmluZ1Byb3h5Sm9iQ2xhc3NOYW1lUHJvdmlkZXIuamF2YQ==) | | |
| [...ng/core/setup/SpringProxyJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvc3ByaW5nL2NvcmUvc2V0dXAvU3ByaW5nUHJveHlKb2JDbGFzc05hbWVQcm92aWRlci5qYXZh) | `80.00% <0.00%> (ø)` | |
| [...asticjob/lite/spring/core/util/AopTargetUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvc3ByaW5nL2NvcmUvdXRpbC9Bb3BUYXJnZXRVdGlscy5qYXZh) | `76.92% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b2b15d...b00b3fe](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29f7b4d) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/aac91a38c09037e14a7e761307ec39dda970cdf4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac91a3) will **decrease** coverage by `0.14%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1956 +/- ##
============================================
- Coverage 85.75% 85.61% -0.15%
+ Complexity 138 136 -2
============================================
Files 277 277
Lines 6038 6041 +3
Branches 917 918 +1
============================================
- Hits 5178 5172 -6
- Misses 525 530 +5
- Partials 335 339 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../datasource/DataSourceTracingStorageConverter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvZGF0YXNvdXJjZS9EYXRhU291cmNlVHJhY2luZ1N0b3JhZ2VDb252ZXJ0ZXIuamF2YQ==) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| [...asticjob/lite/internal/storage/JobNodeStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlU3RvcmFnZS5qYXZh) | `87.50% <0.00%> (-5.36%)` | :arrow_down: |
| [...ob/error/handler/wechat/WechatJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci13ZWNoYXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvZXJyb3IvaGFuZGxlci93ZWNoYXQvV2VjaGF0Sm9iRXJyb3JIYW5kbGVyLmphdmE=) | `89.47% <0.00%> (-2.64%)` | :arrow_down: |
| [...rror/handler/dingtalk/DingtalkJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1kaW5ndGFsay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2Rpbmd0YWxrL0Rpbmd0YWxrSm9iRXJyb3JIYW5kbGVyLmphdmE=) | `88.46% <0.00%> (-1.93%)` | :arrow_down: |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `65.71% <0.00%> (-1.43%)` | :arrow_down: |
| [...b/cloud/console/controller/CloudJobController.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL2NvbnRyb2xsZXIvQ2xvdWRKb2JDb250cm9sbGVyLmphdmE=) | `68.31% <0.00%> (-1.00%)` | :arrow_down: |
| [...ticjob/tracing/rdb/storage/RDBJobEventStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvc3RvcmFnZS9SREJKb2JFdmVudFN0b3JhZ2UuamF2YQ==) | `81.39% <0.00%> (-0.47%)` | :arrow_down: |
| [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `72.80% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aac91a3...29f7b4d](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org