You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by if...@apache.org on 2026/08/04 05:20:56 UTC
(cassandra-simulator) 06/22: Avoid syncrhonizing
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/cassandra-simulator.git
commit 121464aed3a7a4a466c70c145da8f6dce3658a58
Author: Alex Petrov <ol...@gmail.com>
AuthorDate: Fri Jul 17 21:12:28 2026 +0200
Avoid syncrhonizing
---
.../simulator/step/ObservableActions.java | 27 ++++++++--------------
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/simulator-core/src/main/java/org/apache/cassandra/simulator/step/ObservableActions.java b/simulator-core/src/main/java/org/apache/cassandra/simulator/step/ObservableActions.java
index fd08f84..62b117f 100644
--- a/simulator-core/src/main/java/org/apache/cassandra/simulator/step/ObservableActions.java
+++ b/simulator-core/src/main/java/org/apache/cassandra/simulator/step/ObservableActions.java
@@ -66,7 +66,7 @@ public final class ObservableActions
public static void emit(ObservableAction.Kind kind)
{
Sink sink = ObservableActions.sink;
- if (sink != null)
+ if (isEnabled())
sink.emit(kind, null, Thread.currentThread(), null, null);
}
@@ -100,31 +100,22 @@ public final class ObservableActions
target == null ? null : target.getId(),
target == null ? null : target.getName(),
stackTrace, detail);
- synchronized (actions)
- {
- actions.add(action);
- }
+ actions.add(action);
}
public Optional<ObservableAction> lastAction()
{
- synchronized (actions)
- {
- return actions.isEmpty() ? Optional.empty() : Optional.of(actions.get(actions.size() - 1));
- }
+ return actions.isEmpty() ? Optional.empty() : Optional.of(actions.get(actions.size() - 1));
}
public List<ObservableAction> drainObservedActions()
{
- synchronized (actions)
- {
- if (drained == actions.size())
- return java.util.Collections.emptyList();
-
- List<ObservableAction> result = new ArrayList<>(actions.subList(drained, actions.size()));
- drained = actions.size();
- return result;
- }
+ if (drained == actions.size())
+ return Collections.emptyList();
+
+ List<ObservableAction> result = new ArrayList<>(actions.subList(drained, actions.size()));
+ drained = actions.size();
+ return result;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org