You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2026/04/22 23:36:28 UTC
[PR] improves monitor tserver view [accumulo]
keith-turner opened a new pull request, #6329:
URL: https://github.com/apache/accumulo/pull/6329
Made a few major changes in the this PR all in support of providing an improved tserver page on the monitor.
* Gave the RPC thread a consistent name across all server types. This was done to make the thread name findable in a metrics tag using a constant.
* Setup a custom monitor metrics registry. This was done because it may not be safe to read from registry in another thread (see micrometer-metrics/micrometer#7417) AND more importantly to get step functionality where metrics like function counters show the delta for the last 30 seconds.
* Refactored the SeversView code to be more flexible. It used to directly compute data from a a single metric. Now its easier to do arbitrary reductions on a collection of metrics for the data in a column.
* Started collecting executor metrics on thread pools and used those to create some of the tserver columns in the monitor. Using the metrics requires looking for specific thread pool names in the tags.
* Added a new meric to track scan errors.
* Fixed some incorrect metrics types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improves monitor tserver view [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #6329:
URL: https://github.com/apache/accumulo/pull/6329#issuecomment-4305715004
There are columns for queued and completed scans and RPCs. Is there a metric for the number that are currently in-progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improves monitor tserver view [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6329:
URL: https://github.com/apache/accumulo/pull/6329#discussion_r3132577817
##########
core/src/main/java/org/apache/accumulo/core/metrics/Metric.java:
##########
@@ -228,9 +228,10 @@ public enum Metric {
TSERVER_INGEST_BYTES("accumulo.ingest.bytes", MetricType.GAUGE,
"Ingest byte count. The rate can be derived from this metric.",
MetricDocSection.TABLET_SERVER, "Bytes Ingested", null, BYTES),
+ // TODO does this duration expect millis in javascript?
TSERVER_HOLD("accumulo.ingest.hold", MetricType.GAUGE,
"Duration for which commits have been held in milliseconds.", MetricDocSection.TABLET_SERVER,
- "Ingest Commit Hold Time", null, NUMBER),
+ "Hold Time", null, DURATION),
Review Comment:
The `null` parameter here is for the column description. It's used as the text displayed in the Monitor UI when hovering over the column header in a table. When `null` is present the value defaults to the property description. In some cases we may want to be more descriptive in the monitor as "Hold Time" may not mean something to a novice (or experienced) user. In some cases we could be very descriptive in the Monitor telling the user what the column value means and what may cause it. For example,
```
Duration for which the TabletServer has not been accepting new mutations. The acceptance of new mutations are held as the TabletServer is waiting for some other activity to complete. This is typically a sync of the write-ahead log or a minor compaction. Frequent small hold times are normal whereas large hold times could indicate a problem that needs to be investigated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improves monitor tserver view [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #6329:
URL: https://github.com/apache/accumulo/pull/6329#discussion_r3127453563
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -99,14 +99,16 @@ public static void startServer(AbstractServer server, Logger LOG) throws Excepti
private final AtomicBoolean closed = new AtomicBoolean(false);
private final Set<String> monitorMetricExclusions;
+ @SuppressWarnings("deprecation")
protected AbstractServer(ServerId.Type serverType, ServerOpts opts,
BiFunction<SiteConfiguration,ResourceGroupId,ServerContext> serverContextFactory,
String[] args) {
log = LoggerFactory.getLogger(getClass());
this.applicationName = serverType.name();
opts.parseArgs(applicationName, args);
var siteConfig = opts.getSiteConfiguration();
- final String newBindParameter = siteConfig.get(Property.RPC_PROCESS_BIND_ADDRESS);
+ final String newBindParameter = siteConfig.get(siteConfig
Review Comment:
This is a bug found while testing this, need to pull this in to a separate PR and some script changes are also needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improves monitor tserver view [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #6329:
URL: https://github.com/apache/accumulo/pull/6329#issuecomment-4300647043
This is a screenshot of the updated tserver page. Notice the new rates, these will make sorting on data much easier. Before there were ever increasing counts which make sorting not as useful when some tsevers have been running for months and some just restarted. The rates are based on the last 30 seconds of count increments for each tserver this is comes from the new registry.
<img width="2252" height="518" alt="Screenshot at 2026-04-22 18-52-14" src="https://github.com/user-attachments/assets/32ccc071-efba-4435-bc0b-ba28e5c40bf1" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improves monitor tserver view [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #6329:
URL: https://github.com/apache/accumulo/pull/6329#issuecomment-4306044588
> There are columns for queued and completed scans and RPCs. Is there a metric for the number that are currently in-progress?
Yes I believe the following metric is a Gauge that shows this.
```
2026-04-23T14:34:39,292 Thread[77] [accumulo.METRICS] INFO : executor.active{host=localhost,instance.name=uno,name=accumulo.pool.scan.default,port=9800,process.name=TABLET_SERVER,resource.group=accumulo_fate} value=1 threads
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improves monitor tserver view [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #6329:
URL: https://github.com/apache/accumulo/pull/6329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org