[GitHub] emilianbold commented on issue #295: Drop usage of FileInput/OutputStreams - modules a* -> c*

[GitBox <gi...@apache.org>]

emilianbold commented on issue #295: Drop usage of FileInput/OutputStreams - modules a* -> c*
URL: https://github.com/apache/incubator-netbeans/pull/295#issuecomment-347329914
 
 
   >"but don't like so much" - so, are you against this FI/OS change in general?
   
   try-with-resources seems a clear gain because it removes so many finally blocks that just close the stream.
   
   `Files.newInputStream` just looks more ugly with the extra path creation, StandardOpenOption flags, etc.
   
   AFAIK FileInputStream is not outright deprecated and I'm curious if there's really any kind of noticeable impact during normal IDE usage (editing a source file, running the project, etc).
   
   For startup having the most efficient code is important so it would be interesting to narrow down the core modules that need this upgrade.
   
   Basically I would slice-and-dice this into more commits / PRs and even have places where the old code is left alone (because I'm not convinced it has a noticeable effect and there's really no urgent need to switch to the new API and abandon FileInputStream forever).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services