You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "maobaolong (via GitHub)" <gi...@apache.org> on 2024/07/26 01:42:48 UTC
[PR] [FOLLOWUP] [#1401] Fix(dashboard): fix to display app reg time within app page of dashboard [incubator-uniffle]
maobaolong opened a new pull request, #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Display app reg time in dashboard.
### Why are the changes needed?
Fix: Fix typo error introduced by #1868
### Does this PR introduce _any_ user-facing change?
User can see app reg time from dashboard.
### How was this patch tested?
Open a dashboard ui and submit an application and check the app reg time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): fix to display app reg time within app page of dashboard [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963#issuecomment-2252044638
> > @yl09099 Hi, Would you like to take a look at this PR? Thanks.
>
> You should add a space, otherwise you can't sort. eg: el-table-column sortable
@yl09099 the sortable is over here
<img width="1038" alt="image" src="https://github.com/user-attachments/assets/88f3403d-2532-4b63-a3b5-d6933eacdb59">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): fix to display app reg time within app page of dashboard [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963#issuecomment-2251831174
## Test Results
2 732 files +10 2 732 suites +10 5h 37m 55s :stopwatch: + 4m 2s
969 tests ± 0 968 :white_check_mark: + 1 1 :zzz: ±0 0 :x: ±0
12 144 runs +10 12 129 :white_check_mark: +11 15 :zzz: ±0 0 :x: ±0
Results for commit 2b954bac. ± Comparison against base commit c3d8a804.
[test-results]:data:application/gzip;base64,H4sIALgEo2YC/03MTQ7CIBCG4as0rF3AFGzHyxiYQkLsj6GwMt5d2hRk+T0zeT/M+dnu7NHB0MOtY3vysd1TCjr6bT2Ew6Ay5Xs8PvCOZT33RHTS+KeXf2cSFZz2cwZewYawhUtCWo+mACHlNUs0G2C1q6oKNNVzt1HalsXHPBgYVNJock4Sp97iRJJLA6RGRJiMBRBaq559fxL/RP8SAQAA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): fix to display app reg time within app page of dashboard [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on code in PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963#discussion_r1692557658
##########
dashboard/src/main/webapp/src/pages/ApplicationPage.vue:
##########
@@ -55,7 +55,7 @@
>
<el-table-column prop="appId" label="AppId" min-width="180" sortable fixed />
<el-table-column prop="userName" label="UserName" min-width="180" sortable />
- <el-table-columnsortable
+ <el-table-column
prop="registrationTime"
label="Registration Time"
min-width="180"
Review Comment:
The sortable is in L63
https://github.com/apache/incubator-uniffle/pull/1963/files#diff-f9bf9c7f3ab29a053cbc120fd3db975dce2e1f52b4e4295b90e08aaa840930c9R63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): fix to display app reg time within app page of dashboard [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on code in PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963#discussion_r1692559018
##########
dashboard/src/main/webapp/src/pages/ApplicationPage.vue:
##########
@@ -55,7 +55,7 @@
>
<el-table-column prop="appId" label="AppId" min-width="180" sortable fixed />
<el-table-column prop="userName" label="UserName" min-width="180" sortable />
- <el-table-columnsortable
+ <el-table-column
prop="registrationTime"
label="Registration Time"
min-width="180"
Review Comment:
> The sortable is in L63
>
> https://github.com/apache/incubator-uniffle/pull/1963/files#diff-f9bf9c7f3ab29a053cbc120fd3db975dce2e1f52b4e4295b90e08aaa840930c9R63
OK. LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): fix to display app reg time within app page of dashboard [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963#issuecomment-2251797133
@yl09099 Hi, Would you like to take a look at this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): Fix the display of app reg time on app page [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963#issuecomment-2252082638
@rickyma @yl09099 Thanks for your review！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): fix to display app reg time within app page of dashboard [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963#issuecomment-2252028446
> @yl09099 Hi, Would you like to take a look at this PR? Thanks.
You should add a space, otherwise you can't sort. eg: el-table-column sortable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): Fix the display of app reg time on app page [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963#issuecomment-2252081788
Merged to master. Thanks @maobaolong @yl09099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [FOLLOWUP] [#1401] Fix(dashboard): Fix the display of app reg time on app page [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma merged PR #1963:
URL: https://github.com/apache/incubator-uniffle/pull/1963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org