You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/09/16 10:35:03 UTC

Review Request 51951: LENS-1323: TestRemoteHiveDriver#testMultiThreadClient failing in pre-commit builds

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51951/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1323
    https://issues.apache.org/jira/browse/LENS-1323


Repository: lens


Description
-------

The issue originated after LENS-1243. Apparently querying the status twice from Hive server is resulting in an error.


Diffs
-----

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 0218be3ecbfe83282c5710da733df787ce45acac 

Diff: https://reviews.apache.org/r/51951/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51951: LENS-1323: TestRemoteHiveDriver#testMultiThreadClient failing in pre-commit builds

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51951/#review149320
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Sept. 16, 2016, 1:36 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51951/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 1:36 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1323
>     https://issues.apache.org/jira/browse/LENS-1323
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> The issue originated after LENS-1243. Apparently querying the status twice from Hive server is resulting in an error.
> 
> 
> Diffs
> -----
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 0218be3ecbfe83282c5710da733df787ce45acac 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 8a776a8fc7fab5e7f60046efff1fd8cb0afd21ff 
> 
> Diff: https://reviews.apache.org/r/51951/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 51951: LENS-1323: TestRemoteHiveDriver#testMultiThreadClient failing in pre-commit builds

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51951/
-----------------------------------------------------------

(Updated Sept. 16, 2016, 7:06 p.m.)


Review request for lens.


Bugs: LENS-1323
    https://issues.apache.org/jira/browse/LENS-1323


Repository: lens


Description
-------

The issue originated after LENS-1243. Apparently querying the status twice from Hive server is resulting in an error.


Diffs (updated)
-----

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 0218be3ecbfe83282c5710da733df787ce45acac 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 8a776a8fc7fab5e7f60046efff1fd8cb0afd21ff 

Diff: https://reviews.apache.org/r/51951/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51951: LENS-1323: TestRemoteHiveDriver#testMultiThreadClient failing in pre-commit builds

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51951/#review149187
-----------------------------------------------------------



Can you fix TestRemoteHiveDriver#testMultiThreadClient as well to close query only after all threads join ?

- Amareshwari Sriramadasu


On Sept. 16, 2016, 10:35 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51951/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 10:35 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1323
>     https://issues.apache.org/jira/browse/LENS-1323
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> The issue originated after LENS-1243. Apparently querying the status twice from Hive server is resulting in an error.
> 
> 
> Diffs
> -----
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 0218be3ecbfe83282c5710da733df787ce45acac 
> 
> Diff: https://reviews.apache.org/r/51951/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>