You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Kannan Muthukkaruppan (JIRA)" <ji...@apache.org> on 2010/03/04 02:07:27 UTC
[jira] Created: (HBASE-2284) fsWriteLatency metric may be
incorrectly reported
fsWriteLatency metric may be incorrectly reported
--------------------------------------------------
Key: HBASE-2284
URL: https://issues.apache.org/jira/browse/HBASE-2284
Project: Hadoop HBase
Issue Type: Bug
Reporter: Kannan Muthukkaruppan
Priority: Minor
fsWriteLatency metric is computed by maintaining writeTime & writeOps in HLog. If an HLog.append() carries multiple edits, then "writeTime" is computed incorrectly for the subsequent edits because doWrite() is called for each of the edits with the same start time argument ("now").
This also causes a lot of false WARN spews to the log. Only one of the edits might have taken a long time, but every edit after that in a given HLog.append() operation will also raise these warning messages.
{code}
2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302227
2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302228
2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302229
2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302230
2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302231
{code}
Will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2284) fsWriteLatency metric may be
incorrectly reported
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841458#action_12841458 ]
Jean-Daniel Cryans commented on HBASE-2284:
-------------------------------------------
I just committed a fix for mdc_replication since it wasn't compiling anymore.
> fsWriteLatency metric may be incorrectly reported
> --------------------------------------------------
>
> Key: HBASE-2284
> URL: https://issues.apache.org/jira/browse/HBASE-2284
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Kannan Muthukkaruppan
> Assignee: Kannan Muthukkaruppan
> Priority: Minor
> Fix For: 0.20.4, 0.21.0
>
> Attachments: 2284_0.20.patch
>
>
> fsWriteLatency metric is computed by maintaining writeTime & writeOps in HLog. If an HLog.append() carries multiple edits, then "writeTime" is computed incorrectly for the subsequent edits because doWrite() is called for each of the edits with the same start time argument ("now").
> This also causes a lot of false WARN spews to the log. Only one of the edits might have taken a long time, but every edit after that in a given HLog.append() operation will also raise these warning messages.
> {code}
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302227
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302228
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302229
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302230
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302231
> {code}
> Will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2284) fsWriteLatency metric may be
incorrectly reported
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-2284.
--------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
0.20.4
Hadoop Flags: [Reviewed]
Applied to branch and a version to trunk. Thanks for patch Kannan.
> fsWriteLatency metric may be incorrectly reported
> --------------------------------------------------
>
> Key: HBASE-2284
> URL: https://issues.apache.org/jira/browse/HBASE-2284
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Kannan Muthukkaruppan
> Priority: Minor
> Fix For: 0.20.4, 0.21.0
>
> Attachments: 2284_0.20.patch
>
>
> fsWriteLatency metric is computed by maintaining writeTime & writeOps in HLog. If an HLog.append() carries multiple edits, then "writeTime" is computed incorrectly for the subsequent edits because doWrite() is called for each of the edits with the same start time argument ("now").
> This also causes a lot of false WARN spews to the log. Only one of the edits might have taken a long time, but every edit after that in a given HLog.append() operation will also raise these warning messages.
> {code}
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302227
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302228
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302229
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302230
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302231
> {code}
> Will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2284) fsWriteLatency metric may be
incorrectly reported
Posted by "Kannan Muthukkaruppan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kannan Muthukkaruppan updated HBASE-2284:
-----------------------------------------
Attachment: 2284_0.20.patch
> fsWriteLatency metric may be incorrectly reported
> --------------------------------------------------
>
> Key: HBASE-2284
> URL: https://issues.apache.org/jira/browse/HBASE-2284
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Kannan Muthukkaruppan
> Priority: Minor
> Attachments: 2284_0.20.patch
>
>
> fsWriteLatency metric is computed by maintaining writeTime & writeOps in HLog. If an HLog.append() carries multiple edits, then "writeTime" is computed incorrectly for the subsequent edits because doWrite() is called for each of the edits with the same start time argument ("now").
> This also causes a lot of false WARN spews to the log. Only one of the edits might have taken a long time, but every edit after that in a given HLog.append() operation will also raise these warning messages.
> {code}
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302227
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302228
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302229
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302230
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302231
> {code}
> Will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-2284) fsWriteLatency metric may be
incorrectly reported
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-2284:
----------------------------
Assignee: Kannan Muthukkaruppan
Made Kannan a contributor. Assigning him this issue.
> fsWriteLatency metric may be incorrectly reported
> --------------------------------------------------
>
> Key: HBASE-2284
> URL: https://issues.apache.org/jira/browse/HBASE-2284
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Kannan Muthukkaruppan
> Assignee: Kannan Muthukkaruppan
> Priority: Minor
> Fix For: 0.20.4, 0.21.0
>
> Attachments: 2284_0.20.patch
>
>
> fsWriteLatency metric is computed by maintaining writeTime & writeOps in HLog. If an HLog.append() carries multiple edits, then "writeTime" is computed incorrectly for the subsequent edits because doWrite() is called for each of the edits with the same start time argument ("now").
> This also causes a lot of false WARN spews to the log. Only one of the edits might have taken a long time, but every edit after that in a given HLog.append() operation will also raise these warning messages.
> {code}
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302227
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302228
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302229
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302230
> 2010-03-03 11:00:42,247 WARN org.apache.hadoop.hbase.regionserver.HLog: IPC Server handler 51 on 60020 took 1814ms appending an edit to hlog; editcount=302231
> {code}
> Will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.