[GitHub] [fineract] vorburger commented on pull request #820: [WIP] FINERACT-846: Migrating to Java 11

[GitBox <gi...@apache.org>]

vorburger commented on pull request #820:
URL: https://github.com/apache/fineract/pull/820#issuecomment-625123674


   @ptuomola wow, great job, nice find re. JDK!!! I'm just curious, did you notice this by comparison of Travis's VS local JDK version numbers, or do you have a link to a OpenJDK bug about this?
   
   Using JDK 12 instead of 11 can't stay long, because even though Gradle specifies 11, that will only cause javac to allow only 11 SYNTAX, but it will still allow to build with use of 12 LIBRARIES - I've dealt with related problems in other projects, over the years. But what I think we should do due to OpenJDK bug is still do this, for now, merge, but then change it "soon". I volunteer to look into it for Travis later. Perhaps create a new JIRA dedicated to "Switch Travis from Java 12 to Java 11" (and assign it to me)?
   
   As for javac compiler warnings, let's fix in follow up PRs. Personally I may even have left the warning instead of suppressing, as a reminder, but it really doesn't matter, ignore. 
   
   I was also going to suggest that this could have been broken up into separate PRs first for all the code changes, while still on Java 8, and then figure out make the Java 11 build changes, but seeing your breakthrough, I'll get this in ASAP; so more of a suggestion for future smaller PRs.
   
   Let me fully review this by staring at the diff a little longer after work today, and likely merge ASAP.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org