Re: svn commit: r1747400 - /sling/trunk/testing/http/clients/src/test/java/org/apache/sling/testing/DelayRequestInterceptorTest.java

[Robert Munteanu <ro...@apache.org>]

Hi Andrei,

On Wed, 2016-06-08 at 14:30 +0000, dulvac@apache.org wrote:
> -��������DelayRequestInterceptor interceptor = new
> DelayRequestInterceptor(1000);
> +��������DelayRequestInterceptor interceptor = new
> DelayRequestInterceptor(700);

This type of timeout tweaking might be better served by using a
TimeoutsProvider [1] , which has a configurable multiplier.

Thanks,

Robert


[1]:�https://github.com/apache/sling/blob/bbe394c21d8fe449dfd01b0f1c3e4
f102dbbfda7/testing/tools/src/main/java/org/apache/sling/testing/tools/
sling/TimeoutsProvider.java

Re: svn commit: r1747400 - /sling/trunk/testing/http/clients/src/test/java/org/apache/sling/testing/DelayRequestInterceptorTest.java

[Andrei Dulvac <an...@gmail.com>]

Hi Robert,

That's a unit test for the sling http testing clients themselves and I only
made that change to test my svn rights :)
But thanks for pointing that out, I'll make sure to use the
timeoutsprovider wherever there's a sleep in the tooling.
Thanks.

On Thu, Jun 9, 2016 at 2:53 PM Robert Munteanu <ro...@apache.org> wrote:

> Hi Andrei,
>
> On Wed, 2016-06-08 at 14:30 +0000, dulvac@apache.org wrote:
> > -        DelayRequestInterceptor interceptor = new
> > DelayRequestInterceptor(1000);
> > +        DelayRequestInterceptor interceptor = new
> > DelayRequestInterceptor(700);
>
> This type of timeout tweaking might be better served by using a
> TimeoutsProvider [1] , which has a configurable multiplier.
>
> Thanks,
>
> Robert
>
>
> [1]: https://github.com/apache/sling/blob/bbe394c21d8fe449dfd01b0f1c3e4
> f102dbbfda7/testing/tools/src/main/java/org/apache/sling/testing/tools/
> sling/TimeoutsProvider.java
> <https://github.com/apache/sling/blob/bbe394c21d8fe449dfd01b0f1c3e4f102dbbfda7/testing/tools/src/main/java/org/apache/sling/testing/tools/sling/TimeoutsProvider.java>
>