You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "rnewson (via GitHub)" <gi...@apache.org> on 2024/06/06 21:41:44 UTC

[PR] IndexManager keep at least one index open [couchdb]

rnewson opened a new pull request, #5081:
URL: https://github.com/apache/couchdb/pull/5081

   the IndexHealthCheckTest intermittently fails we think because Caffeine is closing the index (flagged to be deleted on close) while the health check is running, as the test IndexManager had a maxIndexesOpen of 0, since that is what the int member variable is initialised to if not set explicitly.
   
   I add --rerun so we can invoke the test suite over and over (gradle would otherwise decline, as it "knows" nothing has changed in the code to warrant a new test run)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IndexManager keep at least one index open [couchdb]

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on PR #5081:
URL: https://github.com/apache/couchdb/pull/5081#issuecomment-2154274544

   @nickva good catch, that was also because idleseconds defaults to zero.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IndexManager keep at least one index open [couchdb]

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #5081:
URL: https://github.com/apache/couchdb/pull/5081#issuecomment-2153506510

   Interestingly, the failure is not always the same. In a previous run on main the reason for closure was `SIZE` while in the case above it's `EXPIRED`
   
   ```
   
   [2024-06-06T20:54:41.651Z] IndexHealthCheckTest > testIndexHealthCheck(Path) STANDARD_OUT
   [2024-06-06T20:54:41.651Z]     20:54:41.136 [Test worker] INFO org.apache.couchdb.nouveau.core.IndexManager -- deleting indexes below ___test9 (excluding nothing)
   [2024-06-06T20:54:41.651Z]     20:54:41.168 [ForkJoinPool.commonPool-worker-3] INFO org.apache.couchdb.nouveau.core.IndexManager -- opening ___test9
   [2024-06-06T20:54:41.996Z]     20:54:41.554 [ForkJoinPool.commonPool-worker-5] INFO org.apache.couchdb.nouveau.core.IndexManager -- closing ___test9 for cause SIZE
   [2024-06-06T20:54:41.996Z]     20:54:41.596 [ForkJoinPool.commonPool-worker-5] DEBUG org.apache.couchdb.nouveau.core.IndexManager -- committed ___test9 before close
   [2024-06-06T20:54:41.996Z]     20:54:41.706 [ForkJoinPool.commonPool-worker-3] INFO org.apache.couchdb.nouveau.core.IndexManager -- opening ___test9
   [2024-06-06T20:54:41.996Z]     20:54:41.723 [ForkJoinPool.commonPool-worker-7] INFO org.apache.couchdb.nouveau.core.IndexManager -- closing ___test9 for cause SIZE
   [2024-06-06T20:54:41.996Z]     20:54:41.890 [Test worker] INFO org.apache.couchdb.nouveau.core.IndexManager -- deleting indexes below ___test9 (excluding nothing)
   [2024-06-06T20:54:42.464Z] 
   [2024-06-06T20:54:42.464Z] IndexHealthCheckTest > testIndexHealthCheck(Path) FAILED
   [2024-06-06T20:54:42.464Z]     org.opentest4j.AssertionFailedError: Result{isHealthy=false, message=Wrong number of search results, expected 1, got 0, duration=0, timestamp=2024-06-06T20:54:41.890Z} ==> expected: <true> but was: <false>
   [2024-06-06T20:54:42.464Z]         at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
   [2024-06-06T20:54:42.464Z]         at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
   [2024-06-06T20:54:42.464Z]         at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
   [2024-06-06T20:54:42.464Z]         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
   [2024-06-06T20:54:42.464Z]         at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
   [2024-06-06T20:54:42.464Z]         at app//org.apache.couchdb.nouveau.health.IndexHealthCheckTest.testIndexHealthCheck(IndexHealthCheckTest.java:45)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Ensure index is up to date when querying [couchdb]

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson merged PR #5081:
URL: https://github.com/apache/couchdb/pull/5081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IndexManager keep at least one index open [couchdb]

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #5081:
URL: https://github.com/apache/couchdb/pull/5081#issuecomment-2153487854

   It did show one failure:
   
   ```
   024-06-06T22:09:44.508Z] Caching disabled for task ':test' because:
   
   [2024-06-06T22:09:44.508Z]   Build cache is disabled
   
   [2024-06-06T22:09:44.508Z] Task ':test' is not up-to-date because:
   
   [2024-06-06T22:09:44.508Z]   Task.upToDateWhen is false.
   
   [2024-06-06T22:09:44.508Z] Starting process 'Gradle Test Executor 1'. Working directory: /home/jenkins/workspace/jenkins-cm1_PullRequests_PR-5081/25.3.2.12/build/apache-couchdb-3.3.3-89a5769/nouveau Command: /opt/java/openjdk/bin/java -Dorg.gradle.internal.worker.tmpdir=/home/jenkins/workspace/jenkins-cm1_PullRequests_PR-5081/25.3.2.12/build/apache-couchdb-3.3.3-89a5769/nouveau/build/tmp/test/work -Dorg.gradle.native=false -javaagent:/home/jenkins/workspace/jenkins-cm1_PullRequests_PR-5081/25.3.2.12/build/apache-couchdb-3.3.3-89a5769/nouveau/build/tmp/.cache/expanded/zip_cde35f471dab581134460fc9a50e2c59/jacocoagent.jar=destfile=build/jacoco/test.exec,append=true,inclnolocationclasses=false,dumponexit=true,output=file,jmx=false @/home/jenkins/.gradle/.tmp/gradle-worker-classpath17310477907838578221txt -Xmx512m -Dfile.encoding=US-ASCII -Duser.country=US -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 1'
   
   [2024-06-06T22:09:44.508Z] Successfully started process 'Gradle Test Executor 1'
   [2024-06-06T22:09:45.706Z] 
   [2024-06-06T22:09:45.706Z] IndexHealthCheckTest > testIndexHealthCheck(Path) STANDARD_OUT
   [2024-06-06T22:09:45.706Z]     22:09:45.555 [Test worker] INFO org.apache.couchdb.nouveau.core.IndexManager -- deleting indexes below ___test9 (excluding nothing)
   [2024-06-06T22:09:45.706Z]     22:09:45.586 [ForkJoinPool.commonPool-worker-3] INFO org.apache.couchdb.nouveau.core.IndexManager -- opening ___test9
   [2024-06-06T22:09:46.052Z]     22:09:45.985 [Test worker] INFO org.apache.couchdb.nouveau.core.IndexManager -- closing ___test9 for cause EXPIRED
   [2024-06-06T22:09:46.398Z]     22:09:46.167 [Test worker] DEBUG org.apache.couchdb.nouveau.core.IndexManager -- committed ___test9 before close
   [2024-06-06T22:09:46.398Z]     22:09:46.173 [ForkJoinPool.commonPool-worker-3] INFO org.apache.couchdb.nouveau.core.IndexManager -- opening ___test9
   [2024-06-06T22:09:46.743Z]     22:09:46.366 [Test worker] INFO org.apache.couchdb.nouveau.core.IndexManager -- deleting indexes below ___test9 (excluding nothing)
   [2024-06-06T22:09:47.940Z] 
   [2024-06-06T22:09:47.940Z] Gradle Test Executor 1 finished executing tests.
   [2024-06-06T22:09:47.940Z] 
   [2024-06-06T22:09:47.940Z] > Task :test
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org