You are viewing a plain text version of this content. The canonical link for it is here.

Posted to zeta-commits@incubator.apache.org by je...@apache.org on 2011/04/15 17:03:57 UTC

[zeta-commits] svn commit: r1092766 - /incubator/zetacomponents/website/Pakefile

Author: jeromer
Date: Fri Apr 15 17:03:57 2011
New Revision: 1092766

URL: http://svn.apache.org/viewvc?rev=1092766&view=rev
Log:
- Escaped shell arguments

Modified:
    incubator/zetacomponents/website/Pakefile

Modified: incubator/zetacomponents/website/Pakefile
URL: http://svn.apache.org/viewvc/incubator/zetacomponents/website/Pakefile?rev=1092766&r1=1092765&r2=1092766&view=diff
==============================================================================
--- incubator/zetacomponents/website/Pakefile (original)
+++ incubator/zetacomponents/website/Pakefile Fri Apr 15 17:03:57 2011
@@ -91,12 +91,13 @@ function run_phpdoc( $task, $args )
 
     pake_echo_comment( 'Building PHPDoc for ' . $options['build.name'] );
 
-    // XXX: escape shell args
     $command = $options['php.path'] . ' -d "memory_limit=2500M" -d "xdebug.default_enable=0" '
              . $options['phpdoc.path'] . ' '
-             . '--directory ' . $options['zeta.base'] . ' '
+             . '--directory ' . escapeshellarg( $options['zeta.base'] ) . ' '
              . '--templatebase "phpdoc/" '
-             . '--target "' . $options['build.dir'] . '/phpdoc/' . $options['build.name'] . '/phpdoc" '
+             . '--target ' . escapeshellarg(
+                 $options['build.dir'] . '/phpdoc/' . $options['build.name'] . '/phpdoc'
+             ) . ' '
              . '--ignore "autoload/,*autoload.php,tests/,docs/,design/" '
              . '--hidden false '
              . '--undocumentedelements off '