[GitHub] [tvm] junrushao commented on a diff in pull request #13195: [MetaSchedule] Refactor ScheduleRule Attributes

[GitBox <gi...@apache.org>]

junrushao commented on code in PR #13195:
URL: https://github.com/apache/tvm/pull/13195#discussion_r1016005053


##########
python/tvm/relay/op/strategy/cuda.py:
##########
@@ -166,9 +165,34 @@ def conv2d_strategy_cuda(attrs, inputs, out_type, target):
                     wrap_topi_schedule(topi.cuda.schedule_conv2d_nchw),
                     name="conv2d_nchw.cuda",
                 )
-            _, _, kh, kw = get_const_tuple(kernel.shape)
-            if (
-                (2 < kh < 8 and 2 < kw < 8 and kh == kw)
+            N, _, H, W = get_const_tuple(data.shape)
+            CO, CI, KH, KW = get_const_tuple(kernel.shape)
+            (_, _, judge_winograd_auto_scheduler) = judge_winograd(

Review Comment:
   certainly - it definitely sounds better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org