You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/07/01 06:37:32 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #697: ✨ feat: luajit replace lua

git-hulk commented on code in PR #697:
URL: https://github.com/apache/incubator-kvrocks/pull/697#discussion_r911657229


##########
src/scripting.h:
##########
@@ -23,9 +23,7 @@
 #include <string>
 #include <vector>
 
-#include <lua.h>
-#include <lauxlib.h>
-#include <lualib.h>
+#include <lua.hpp>

Review Comment:
   > I think this header does not solve the issue in #609, and we need some investigation to determine how to avoid memory leaks in c++ in luajit.
   
   @xiaobiaozhao you can try to call `DestroyState` in the Server destructor since it leaks by `cjson` open would init the buffer(1024). But I'm wondering why it happens in luajit only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org