[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3672: include/spawn.h: Add POSIX_SPAWN_SETSID definition

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #3672:
URL: https://github.com/apache/incubator-nuttx/pull/3672#discussion_r628688746



##########
File path: include/spawn.h
##########
@@ -53,6 +53,7 @@
 #define POSIX_SPAWN_SETSCHEDULER  (1 << 3)  /* 1: Set task's scheduler policy */
 #define POSIX_SPAWN_SETSIGDEF     (1 << 4)  /* 1: Set default signal actions */
 #define POSIX_SPAWN_SETSIGMASK    (1 << 5)  /* 1: Set sigmask */
+#define POSIX_SPAWN_SETSID        (1 << 7)  /* 1: Create the new session */

Review comment:
       Here is some reason I don't add the code to check the flag:
   
   1. NuttX doesn't support the session concept, so we can simply model that all processes share a global session and ignore the request safely.
   2. In the standard implementation, tty driver work with the scheduler do some special action for the different session, but the difference is very minor and NuttX actually treat that all processes are equal regarding the session. It isn't good to stop the program just because the minor(no for NuttX) difference.
   
   @gustavonihei what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org