You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by re...@apache.org on 2019/11/21 12:09:41 UTC
svn commit: r1870084 - in /jackrabbit/oak/branches/1.10: ./
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegate.java
Author: reschke
Date: Thu Nov 21 12:09:41 2019
New Revision: 1870084
URL: http://svn.apache.org/viewvc?rev=1870084&view=rev
Log:
OAK-8722: dead locking related code in NodeDelegate.updateMixins (merged r1869367 into 1.10)
Modified:
jackrabbit/oak/branches/1.10/ (props changed)
jackrabbit/oak/branches/1.10/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegate.java
Propchange: jackrabbit/oak/branches/1.10/
------------------------------------------------------------------------------
Merged /jackrabbit/oak/trunk:r1869367
Modified: jackrabbit/oak/branches/1.10/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegate.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.10/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegate.java?rev=1870084&r1=1870083&r2=1870084&view=diff
==============================================================================
--- jackrabbit/oak/branches/1.10/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegate.java (original)
+++ jackrabbit/oak/branches/1.10/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegate.java Thu Nov 21 12:09:41 2019
@@ -438,16 +438,7 @@ public class NodeDelegate extends ItemDe
tree.setProperty(JCR_MIXINTYPES, mixinNames, NAMES);
}
- // 3. deal with locked nodes
- boolean wasLockable = isNodeType(MIX_LOCKABLE);
- boolean isLockable = isNodeType(MIX_LOCKABLE);
- if (wasLockable && !isLockable && holdsLock(false)) {
- // TODO: This should probably be done in a commit hook
- unlock();
- sessionDelegate.refresh(true);
- }
-
- // 4. clean up set of properties and child nodes such that all child items
+ // 3. clean up set of properties and child nodes such that all child items
// have a valid item definition according to the effective node type present
// after having updated the mixin property. this includes removing all
// protected properties and child nodes associated with the removed mixin