You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2012/10/24 08:28:12 UTC
[jira] [Commented] (WICKET-4829) ComponentResolvers created in app
init ignore markup's namespace
[ https://issues.apache.org/jira/browse/WICKET-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483021#comment-13483021 ]
Sven Meier commented on WICKET-4829:
------------------------------------
Although I wasn't able to apply your patch directly, your changes seems to solve this issue.
But before we just fix the code, perhaps we improve the whole situation:
It's unfortunate that AbstractMarkupFilter#markupResourceStream is sometimes set and on other times it's null.
And InlineEnclosureHandler still has "wicket:" prefix in INLINE_ENCLOSURE_ATTRIBUTE_NAME.
I wonder why RelativePathPrefixHandler#getWicketRelativePathPrefix() and others even bother to prefix the id with the namespace? The namespace is the same for the whole markup anyway. Wouldn't it be easier just to skip the prefixing?
> ComponentResolvers created in app init ignore markup's namespace
> ----------------------------------------------------------------
>
> Key: WICKET-4829
> URL: https://issues.apache.org/jira/browse/WICKET-4829
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.2.0
> Environment: Windows, Java 6.x
> Reporter: Chris Colman
> Attachments: nonStdNamespaceBugW6.2.zip
>
>
> Initially this problem was occurring in a page with an enclosure and so I thought it was specific to enclosures but on minimalizing the quickstart it is apparent that it happens on any page where a non default namespace is specified AND a href has a relative path.
>
> The attached quickstart has a single page with no components at all. In 6.x the page fails if a non default namespace is specified in the <html> tag. This works fine in 1.4.x and 1.5.x
> <html xmls:foobar>
> causes:
> Last cause: Unable to find component with id 'foobar_relative_path_prefix_' in [HtmlHeaderContainer [Component id = _header_0]]
> Expected: '_header_0.foobar_relative_path_prefix_'.
> Found with similar names: ''
> If we remove the non standard namespace declaration from the html element then the page works fine.
> Also, if we remove the line:
> <link rel="stylesheet" href="style.css" type="text/css" media="screen" title="Stylesheet"/>
> from the HomePage.html then the problem doesn't occur.
> Problem could possibly be related to how RelativePathPrefixHanlder deals with a non default namespace.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira