You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kristine Hahn (Code Review)" <ge...@cloudera.org> on 2020/04/10 00:02:47 UTC
[Impala-ASF-CR] IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
Kristine Hahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15702
Change subject: IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
......................................................................
IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
Documented read/write support for DATE type in 3.4.
Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
---
M docs/topics/impala_date.xml
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/15702/1
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
[Impala-ASF-CR] IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15702
to look at the new patch set (#2).
Change subject: IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
......................................................................
IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
Documented read/write support for DATE type in 3.4. Made review changes.
Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
---
M docs/topics/impala_date.xml
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/15702/2
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/580/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Apr 2020 00:15:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/580/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Apr 2020 00:02:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/586/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 13:51:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 19:11:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type
......................................................................
Patch Set 1:
(3 comments)
Hi Kristine, thank you for this change. I only had 2 minor comments and 1 nit.
http://gerrit.cloudera.org:8080/#/c/15702/1/docs/topics/impala_date.xml
File docs/topics/impala_date.xml:
http://gerrit.cloudera.org:8080/#/c/15702/1/docs/topics/impala_date.xml@44
PS1, Line 44: <p> Use the <codeph>DATE</codeph> data type to store date values. The
: <codeph>DATE</codeph> type is supported for HBase, Text, Avro, and
: Parquet. </p>
We should add Kudu to this list as well.
http://gerrit.cloudera.org:8080/#/c/15702/1/docs/topics/impala_date.xml@200
PS1, Line 200:
nit: empty space before newline
http://gerrit.cloudera.org:8080/#/c/15702/1/docs/topics/impala_date.xml@203
PS1, Line 203: For example:</p>
: <p>
: <codeblock>
: create table kudu_date_key (fdatekey date primary key, val string)
: stored as kudu
: insert into kudu_date_key values (DATE '1970-01-01', 'Unix epoch'), (DATE '2019-12-12', 'today')
: </codeblock>
I could not find any difference between Kudu and non-Kudu Date type usage, also non-Kudu usage is not documented. So I think this example is not needed here.
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 09:14:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/586/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 13:43:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
......................................................................
IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
Documented read/write support for DATE type in 3.4. Made review changes.
Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Reviewed-on: http://gerrit.cloudera.org:8080/15702
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tamas Mate <tm...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M docs/topics/impala_date.xml
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tamas Mate: Looks good to me, but someone else must approve
Thomas Tauber-Marshall: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639: [DOCS] Document Impala support for Kudu DATE type
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00
Gerrit-Change-Number: 15702
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 18:08:23 +0000
Gerrit-HasComments: No