You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/17 16:34:39 UTC

[GitHub] [spark] mridulm commented on pull request #34018: [SPARK-36772] FinalizeShuffleMerge fails with an exception due to attempt id not matching

mridulm commented on pull request #34018:
URL: https://github.com/apache/spark/pull/34018#issuecomment-921930779


   Discussed with @Ngone51.
   @zhouyejoe can we make the following change please:
   * Move toInt into setAttemptId (which takes String as param).
   * try/catch the Integer.parseInt and log warning in case it is not able to parse attempt id to string.
     * If successful, set attempt id to that value - else leave it unchanged (defaulting to -1).
   * Let us keep the attempt id in BlockStoreClient itself.
   
   Thoughts ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org