You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/12 07:54:58 UTC

[PR] fix: test metrics sources through backend-specific paths [rocketmq-dashboard]

Aias00 opened a new pull request, #1988:
URL: https://github.com/apache/rocketmq-dashboard/pull/1988

   ### Track
   
   RocketMQ Studio Track 1: unified control plane / METRICS-01.
   
   ### Summary
   
   - model both range-query and instant-query paths in `MetricsBackendType`
   - probe VictoriaMetrics and Mimir through their backend-specific Prometheus API prefixes
   - keep Prometheus, Thanos, Cortex, ARMS, and custom backends on the standard instant-query path
   - preserve existing authentication, timeout, redirect, and SSRF protections
   
   ### Verification
   
   - `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -Dtest=SettingsServiceTest,MetricsBackendTypeTest test` (40 tests)
   - `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -DskipTests package`
   - Checkstyle: 0 violations
   
   ### Local baseline note
   
   `MultiBackendMetricsSourceTest` was also run on this branch and the untouched `origin/rocketmq-studio` baseline. Both fail identically in this local environment because the embedded site-local HTTP server cannot be reached; this patch does not modify that runtime test path.
   
   Closes #1987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: test metrics sources through backend-specific paths [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1988:
URL: https://github.com/apache/rocketmq-dashboard/pull/1988#issuecomment-5266796131

   Superseded by #1966, which now contains this backend-specific metrics test path together with the related data source lifecycle fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: test metrics sources through backend-specific paths [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #1988: fix: test metrics sources through backend-specific paths
URL: https://github.com/apache/rocketmq-dashboard/pull/1988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org