You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "pramodbiligiri (via GitHub)" <gi...@apache.org> on 2023/02/06 17:24:39 UTC
[GitHub] [hudi] pramodbiligiri opened a new pull request, #7868: [HUDI-1593] Identifying touchpoints and setting up basic code
pramodbiligiri opened a new pull request, #7868:
URL: https://github.com/apache/hudi/pull/7868
Hudi JIRA: https://issues.apache.org/jira/browse/HUDI-1593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1433193212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
}, {
"hash" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149",
"triggerID" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"triggerType" : "PUSH"
}, {
"hash" : "8c1b7ef38c2276e7b593401a0a35558ee143b7a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15234",
"triggerID" : "8c1b7ef38c2276e7b593401a0a35558ee143b7a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c1b7ef38c2276e7b593401a0a35558ee143b7a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15234)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pramodbiligiri commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "pramodbiligiri (via GitHub)" <gi...@apache.org>.
pramodbiligiri commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1430840601
@nsivabalan One unrelated test in spark3.3 mode is failing, as shown below. Is that something that can be ignored and this PR can be merged?
```
TestCreateTable:
- Test Create Managed Hoodie Table
- Test Create Hoodie Table With Options
- Test Create External Hoodie Table
- Test Table Column Validate
3223519 [Executor task launch worker for task 0.0 in stage 40.0 (TID 51)] ERROR org.apache.spark.util.Utils [] - Aborting task
org.apache.hudi.exception.HoodieKeyException: Record key has to be non-null!
at org.apache.hudi.keygen.BuiltinKeyGenerator.handleNullRecordKey(BuiltinKeyGenerator.java:319) ~[hudi-spark-client-0.14.0-SNAPSHOT.jar:0.14.0-SNAPSHOT]
at org.apache.hudi.keygen.SimpleKeyGenerator.getRecordKey(SimpleKeyGenerator.java:92) ~[hudi-spark-client-0.14.0-SNAPSHOT.jar:0.14.0-SNAPSHOT]
at org.apache.spark.sql.hudi.command.SqlKeyGenerator.$anonfun$getRecordKey$5(SqlKeyGenerator.scala:86) ~[hudi-spark-common_2.12-0.14.0-SNAPSHOT.jar:?]
at scala.Option.map(Option.scala:230) ~[scala-library-2.12.10.jar:?]
at org.apache.spark.sql.hudi.command.SqlKeyGenerator.getRecordKey(SqlKeyGenerator.scala:86) ~[hudi-spark-common_2.12-0.14.0-SNAPSHOT.jar:?]
at org.apache.hudi.HoodieDatasetBulkInsertHelper$.$anonfun$prepareForBulkInsert$2(HoodieDatasetBulkInsertHelper.scala:87) ~[hudi-spark-client-0.14.0-SNAPSHOT.jar:0.14.0-SNAPSHOT]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Identifying touchpoints and setting up basic code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1420831721
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92f22a3e6d220879cdc9d67136ec5995cf6677be Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990)
* 2a178e411ec058c3f56d7b8b4411e225d7d2ed5e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1429341996
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
}, {
"hash" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149",
"triggerID" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 943c91a266397e07f0aa10289ed78ef277ce42f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1422336741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb96da9970f51dd491e2c3963abe8043e32ff943 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036)
* 5b6f539ecdc4ba84b7b509b43bf4c3836c575dca Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pramodbiligiri commented on a diff in pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "pramodbiligiri (via GitHub)" <gi...@apache.org>.
pramodbiligiri commented on code in PR #7868:
URL: https://github.com/apache/hudi/pull/7868#discussion_r1099863259
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/RestoresCommand.java:
##########
@@ -0,0 +1,100 @@
+package org.apache.hudi.cli.commands;
+
+import org.apache.hudi.avro.model.HoodieRestoreMetadata;
+import org.apache.hudi.cli.HoodieCLI;
+import org.apache.hudi.cli.HoodiePrintHelper;
+import org.apache.hudi.cli.HoodieTableHeaderFields;
+import org.apache.hudi.cli.TableHeader;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.springframework.shell.standard.ShellComponent;
+import org.springframework.shell.standard.ShellMethod;
+import org.springframework.shell.standard.ShellOption;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+
+import static org.apache.hudi.common.table.timeline.HoodieTimeline.RESTORE_ACTION;
+
+/**
+ * CLI command to display info about restore actions.
+ */
+@ShellComponent
+public class RestoresCommand {
+
+ @ShellMethod(key = "show restores", value = "List all restore instants")
+ public String showRestores(
+ @ShellOption(value = {"--limit"}, help = "Limit #rows to be displayed", defaultValue = "10") Integer limit,
+ @ShellOption(value = {"--sortBy"}, help = "Sorting Field", defaultValue = "") final String sortByField,
+ @ShellOption(value = {"--desc"}, help = "Ordering", defaultValue = "false") final boolean descending,
Review Comment:
Done. There's a "show restores --inflight" option for the same.
If at all there are any UX related asks for this feature (not sub-features like the inflight one), I'd like to take them all in one batch and preferably in a separate PR after adding it as a story/task. I find it inefficient to tweak the UX one bit at a time. Causes a lot of back-and-forth chatter and wasteful rewrites of the same code piece.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1432610733
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
}, {
"hash" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149",
"triggerID" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"triggerType" : "PUSH"
}, {
"hash" : "8c1b7ef38c2276e7b593401a0a35558ee143b7a8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c1b7ef38c2276e7b593401a0a35558ee143b7a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 943c91a266397e07f0aa10289ed78ef277ce42f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149)
* 8c1b7ef38c2276e7b593401a0a35558ee143b7a8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1422212969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac2c23ac9b0ac610721635b91b8534e2efe6c25 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994)
* fb96da9970f51dd491e2c3963abe8043e32ff943 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1434007162
<img width="1185" alt="Screen Shot 2023-02-16 at 8 55 46 AM" src="https://user-images.githubusercontent.com/513218/219533811-dc990f0c-47ba-400c-859b-acd4193568e3.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #7868:
URL: https://github.com/apache/hudi/pull/7868#discussion_r1099493708
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/RestoresCommand.java:
##########
@@ -0,0 +1,100 @@
+package org.apache.hudi.cli.commands;
+
+import org.apache.hudi.avro.model.HoodieRestoreMetadata;
+import org.apache.hudi.cli.HoodieCLI;
+import org.apache.hudi.cli.HoodiePrintHelper;
+import org.apache.hudi.cli.HoodieTableHeaderFields;
+import org.apache.hudi.cli.TableHeader;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.springframework.shell.standard.ShellComponent;
+import org.springframework.shell.standard.ShellMethod;
+import org.springframework.shell.standard.ShellOption;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+
+import static org.apache.hudi.common.table.timeline.HoodieTimeline.RESTORE_ACTION;
+
+/**
+ * CLI command to display info about restore actions.
+ */
+@ShellComponent
+public class RestoresCommand {
+
+ @ShellMethod(key = "show restores", value = "List all restore instants")
+ public String showRestores(
+ @ShellOption(value = {"--limit"}, help = "Limit #rows to be displayed", defaultValue = "10") Integer limit,
+ @ShellOption(value = {"--sortBy"}, help = "Sorting Field", defaultValue = "") final String sortByField,
+ @ShellOption(value = {"--desc"}, help = "Ordering", defaultValue = "false") final boolean descending,
Review Comment:
can we add an option to list inflight restores as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1423600470
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5b6f539ecdc4ba84b7b509b43bf4c3836c575dca Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Identifying touchpoints and setting up basic code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1420679773
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92f22a3e6d220879cdc9d67136ec5995cf6677be UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1429193581
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
}, {
"hash" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149",
"triggerID" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5b6f539ecdc4ba84b7b509b43bf4c3836c575dca Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038)
* 943c91a266397e07f0aa10289ed78ef277ce42f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1432648625
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
}, {
"hash" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149",
"triggerID" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"triggerType" : "PUSH"
}, {
"hash" : "8c1b7ef38c2276e7b593401a0a35558ee143b7a8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15234",
"triggerID" : "8c1b7ef38c2276e7b593401a0a35558ee143b7a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 943c91a266397e07f0aa10289ed78ef277ce42f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15149)
* 8c1b7ef38c2276e7b593401a0a35558ee143b7a8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15234)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pramodbiligiri commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "pramodbiligiri (via GitHub)" <gi...@apache.org>.
pramodbiligiri commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1420855720
Find sample output from both the commands below:
hudi:tbl1->connect --path /tmp/junit3259117171799396061/TestRestoresCommand_test_table/
Metadata for table TestRestoresCommand_test_table loaded
hudi:TestRestoresCommand_test_table->show restores
2023-02-07 19:27:38.986 INFO 64110 --- [ main] o.a.h.c.t.t.HoodieActiveTimeline : Loaded instants upto : Option{val=[20230207192635085__restore__COMPLETED]}
╔═══════════════════╤══════════════════╤══════════════════════╗
║ Instant │ Restored Instant │ Time taken in millis ║
╠═══════════════════╪══════════════════╪══════════════════════╣
║ 20230207192628161 │ 103 │ 2407 ║
╟───────────────────┼──────────────────┼──────────────────────╢
║ 20230207192635085 │ 106 │ 2033 ║
╚═══════════════════╧══════════════════╧══════════════════════╝
hudi:TestRestoresCommand_test_table->show restore --instant 20230207192628161
╔═══════════════════╤══════════════════╤══════════════════════╗
║ Instant │ Restored Instant │ Time taken in millis ║
╠═══════════════════╪══════════════════╪══════════════════════╣
║ 20230207192628161 │ 103 │ 2407 ║
╚═══════════════════╧══════════════════╧══════════════════════╝
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #7868:
URL: https://github.com/apache/hudi/pull/7868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pramodbiligiri commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "pramodbiligiri (via GitHub)" <gi...@apache.org>.
pramodbiligiri commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1422276111
Added support for showing inflight restores. Below CLI session demonstrates all the use cases of this overall feature:
hudi-cli> connect --path /tmp/junit1696417734320078758/TestRestoresCommand_test_table/
Metadata for table TestRestoresCommand_test_table loaded
hudi:TestRestoresCommand_test_table->show restores
```
╔═══════════════════╤══════════════════╤══════════════════════╤═══════════════╗
║ Instant │ Restored Instant │ Time taken in millis │ Restore State ║
╠═══════════════════╪══════════════════╪══════════════════════╪═══════════════╣
║ 20230208132601135 │ 103 │ 2802 │ COMPLETED ║
╚═══════════════════╧══════════════════╧══════════════════════╧═══════════════╝
```
hudi:TestRestoresCommand_test_table-> show restores --inflight
```
╔═══════════════════╤══════════════════╤══════════════════════╤═══════════════╗
║ Instant │ Restored Instant │ Time taken in millis │ Restore State ║
╠═══════════════════╪══════════════════╪══════════════════════╪═══════════════╣
║ 20230208132601135 │ 103 │ 2802 │ COMPLETED ║
╟───────────────────┼──────────────────┼──────────────────────┼───────────────╢
║ 20230208132612262 │ 106 │ │ INFLIGHT ║
╚═══════════════════╧══════════════════╧══════════════════════╧═══════════════╝
```
You can validate the above two CLI outputs by looking at the file listing below:
$ ls -tl /tmp/junit1696417734320078758/TestRestoresCommand_test_table/.hoodie/
```
0 Feb 8 13:26 20230208132612262.restore.inflight
631 Feb 8 13:26 20230208132612262.restore.requested
2106 Feb 8 13:26 20230208132601135.restore
0 Feb 8 13:26 20230208132601135.restore.inflight
631 Feb 8 13:26 20230208132601135.restore.requested
```
After finishing the restores, both are shown as COMPLETED as seen below:
hudi:TestRestoresCommand_test_table->show restores --inflight
```
╔═══════════════════╤══════════════════╤══════════════════════╤═══════════════╗
║ Instant │ Restored Instant │ Time taken in millis │ Restore State ║
╠═══════════════════╪══════════════════╪══════════════════════╪═══════════════╣
║ 20230208132601135 │ 103 │ 2802 │ COMPLETED ║
╟───────────────────┼──────────────────┼──────────────────────┼───────────────╢
║ 20230208132612262 │ 106 │ 371157 │ COMPLETED ║
╚═══════════════════╧══════════════════╧══════════════════════╧═══════════════╝
```
Details for a single COMPLETED restore:
hudi:TestRestoresCommand_test_table->show restore --instant 20230208132601135
```
╔═══════════════════╤══════════════════╤══════════════════════╤═══════════════╗
║ Instant │ Restored Instant │ Time taken in millis │ Restore State ║
╠═══════════════════╪══════════════════╪══════════════════════╪═══════════════╣
║ 20230208132601135 │ 103 │ 2802 │ COMPLETED ║
╚═══════════════════╧══════════════════╧══════════════════════╧═══════════════╝
```
Drawn from a different run: Details for a single INFLIGHT restore:
hudi:TestRestoresCommand_test_table->show restore --instant 20230208133608462
```
╔═══════════════════╤══════════════════╤══════════════════════╤═══════════════╗
║ Instant │ Restored Instant │ Time taken in millis │ Restore State ║
╠═══════════════════╪══════════════════╪══════════════════════╪═══════════════╣
║ 20230208133608462 │ 103 │ │ INFLIGHT ║
╚═══════════════════╧══════════════════╧══════════════════════╧═══════════════╝
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1420844246
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92f22a3e6d220879cdc9d67136ec5995cf6677be Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990)
* 2a178e411ec058c3f56d7b8b4411e225d7d2ed5e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Identifying touchpoints and setting up basic code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1420688716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92f22a3e6d220879cdc9d67136ec5995cf6677be Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1429156834
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
}, {
"hash" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "943c91a266397e07f0aa10289ed78ef277ce42f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5b6f539ecdc4ba84b7b509b43bf4c3836c575dca Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15038)
* 943c91a266397e07f0aa10289ed78ef277ce42f9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1421331038
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac2c23ac9b0ac610721635b91b8534e2efe6c25 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1420921570
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92f22a3e6d220879cdc9d67136ec5995cf6677be Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990)
* 2a178e411ec058c3f56d7b8b4411e225d7d2ed5e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991)
* 6ac2c23ac9b0ac610721635b91b8534e2efe6c25 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1420935260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a178e411ec058c3f56d7b8b4411e225d7d2ed5e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991)
* 6ac2c23ac9b0ac610721635b91b8534e2efe6c25 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1422204012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac2c23ac9b0ac610721635b91b8534e2efe6c25 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994)
* fb96da9970f51dd491e2c3963abe8043e32ff943 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1420948471
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a178e411ec058c3f56d7b8b4411e225d7d2ed5e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991)
* 6ac2c23ac9b0ac610721635b91b8534e2efe6c25 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7868:
URL: https://github.com/apache/hudi/pull/7868#issuecomment-1422282343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14990",
"triggerID" : "92f22a3e6d220879cdc9d67136ec5995cf6677be",
"triggerType" : "PUSH"
}, {
"hash" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14991",
"triggerID" : "2a178e411ec058c3f56d7b8b4411e225d7d2ed5e",
"triggerType" : "PUSH"
}, {
"hash" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994",
"triggerID" : "6ac2c23ac9b0ac610721635b91b8534e2efe6c25",
"triggerType" : "PUSH"
}, {
"hash" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036",
"triggerID" : "fb96da9970f51dd491e2c3963abe8043e32ff943",
"triggerType" : "PUSH"
}, {
"hash" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5b6f539ecdc4ba84b7b509b43bf4c3836c575dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac2c23ac9b0ac610721635b91b8534e2efe6c25 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14994)
* fb96da9970f51dd491e2c3963abe8043e32ff943 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15036)
* 5b6f539ecdc4ba84b7b509b43bf4c3836c575dca UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pramodbiligiri commented on a diff in pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "pramodbiligiri (via GitHub)" <gi...@apache.org>.
pramodbiligiri commented on code in PR #7868:
URL: https://github.com/apache/hudi/pull/7868#discussion_r1105318602
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/RestoresCommand.java:
##########
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.cli.commands;
+
+import org.apache.hudi.avro.model.HoodieInstantInfo;
+import org.apache.hudi.avro.model.HoodieRestoreMetadata;
+import org.apache.hudi.avro.model.HoodieRestorePlan;
+import org.apache.hudi.cli.HoodieCLI;
+import org.apache.hudi.cli.HoodiePrintHelper;
+import org.apache.hudi.cli.HoodieTableHeaderFields;
+import org.apache.hudi.cli.TableHeader;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.apache.hudi.common.util.Option;
+import org.springframework.shell.standard.ShellComponent;
+import org.springframework.shell.standard.ShellMethod;
+import org.springframework.shell.standard.ShellOption;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+
+import static org.apache.hudi.common.table.timeline.HoodieTimeline.RESTORE_ACTION;
+
+/**
+ * CLI command to display info about restore actions.
+ */
+@ShellComponent
+public class RestoresCommand {
+
+ @ShellMethod(key = "show restores", value = "List all restore instants")
+ public String showRestores(
+ @ShellOption(value = {"--limit"}, help = "Limit #rows to be displayed", defaultValue = "10") Integer limit,
+ @ShellOption(value = {"--sortBy"}, help = "Sorting Field", defaultValue = "") final String sortByField,
+ @ShellOption(value = {"--desc"}, help = "Ordering", defaultValue = "false") final boolean descending,
+ @ShellOption(value = {"--headeronly"}, help = "Print Header Only",
+ defaultValue = "false") final boolean headerOnly,
+ @ShellOption(value = {"--inflight"}, help = "Also list restores that are in flight",
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #7868: [HUDI-1593] Add support for "show restores" and "show restore" commands in hudi-cli
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #7868:
URL: https://github.com/apache/hudi/pull/7868#discussion_r1105158580
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/RestoresCommand.java:
##########
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.cli.commands;
+
+import org.apache.hudi.avro.model.HoodieInstantInfo;
+import org.apache.hudi.avro.model.HoodieRestoreMetadata;
+import org.apache.hudi.avro.model.HoodieRestorePlan;
+import org.apache.hudi.cli.HoodieCLI;
+import org.apache.hudi.cli.HoodiePrintHelper;
+import org.apache.hudi.cli.HoodieTableHeaderFields;
+import org.apache.hudi.cli.TableHeader;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.apache.hudi.common.util.Option;
+import org.springframework.shell.standard.ShellComponent;
+import org.springframework.shell.standard.ShellMethod;
+import org.springframework.shell.standard.ShellOption;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+
+import static org.apache.hudi.common.table.timeline.HoodieTimeline.RESTORE_ACTION;
+
+/**
+ * CLI command to display info about restore actions.
+ */
+@ShellComponent
+public class RestoresCommand {
+
+ @ShellMethod(key = "show restores", value = "List all restore instants")
+ public String showRestores(
+ @ShellOption(value = {"--limit"}, help = "Limit #rows to be displayed", defaultValue = "10") Integer limit,
+ @ShellOption(value = {"--sortBy"}, help = "Sorting Field", defaultValue = "") final String sortByField,
+ @ShellOption(value = {"--desc"}, help = "Ordering", defaultValue = "false") final boolean descending,
+ @ShellOption(value = {"--headeronly"}, help = "Print Header Only",
+ defaultValue = "false") final boolean headerOnly,
+ @ShellOption(value = {"--inflight"}, help = "Also list restores that are in flight",
Review Comment:
lets name this --includeInflights
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org