You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2012/09/09 05:19:07 UTC

[jira] [Created] (CASSANDRA-4635) BatchlogManagerMBean

Jonathan Ellis created CASSANDRA-4635:
-----------------------------------------

             Summary: BatchlogManagerMBean
                 Key: CASSANDRA-4635
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4635
             Project: Cassandra
          Issue Type: Sub-task
    Affects Versions: 1.2.0 beta 1
            Reporter: Jonathan Ellis
            Assignee: Aleksey Yeschenko
            Priority: Minor
             Fix For: 1.2.0


CASSANDRA-4542 adds an empty BatchlogManagerMBean; we should flesh it out or remove it.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4635) BatchlogManagerMBean

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-4635:
--------------------------------------

    Fix Version/s:     (was: 1.2.0)
                   1.2.0 beta 1
    
> BatchlogManagerMBean
> --------------------
>
>                 Key: CASSANDRA-4635
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4635
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Jonathan Ellis
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0 beta 1
>
>         Attachments: CASSANDRA-4635.patch
>
>
> CASSANDRA-4542 adds an empty BatchlogManagerMBean; we should flesh it out or remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4635) BatchlogManagerMBean

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451469#comment-13451469 ] 

Jonathan Ellis commented on CASSANDRA-4635:
-------------------------------------------

I'd like to see a "how many batches do we have to replay for coordinator X" method, but since we are not keying our entries by the coordinator we'd have to add an index, which probably isn't worth the performance hit.

If we don't provide this, is there any purpose in recording coordinator at all?
                
> BatchlogManagerMBean
> --------------------
>
>                 Key: CASSANDRA-4635
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4635
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Jonathan Ellis
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> CASSANDRA-4542 adds an empty BatchlogManagerMBean; we should flesh it out or remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4635) BatchlogManagerMBean

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451484#comment-13451484 ] 

Jonathan Ellis commented on CASSANDRA-4635:
-------------------------------------------

SGTM.
                
> BatchlogManagerMBean
> --------------------
>
>                 Key: CASSANDRA-4635
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4635
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Jonathan Ellis
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> CASSANDRA-4542 adds an empty BatchlogManagerMBean; we should flesh it out or remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4635) BatchlogManagerMBean

Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Yeschenko updated CASSANDRA-4635:
-----------------------------------------

    Attachment: CASSANDRA-4635.patch
    
> BatchlogManagerMBean
> --------------------
>
>                 Key: CASSANDRA-4635
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4635
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Jonathan Ellis
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: CASSANDRA-4635.patch
>
>
> CASSANDRA-4542 adds an empty BatchlogManagerMBean; we should flesh it out or remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4635) BatchlogManagerMBean

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451475#comment-13451475 ] 

Jonathan Ellis commented on CASSANDRA-4635:
-------------------------------------------

I think I'd rather just rely on timeout.  FD can give false negatives (most often if the local node is under severe memory pressure, so it doesn't process gossiped heartbeats in a timely manner).  Of course if the node is in that much trouble, it probably won't receive the delete on the batch anyway, but either way I don't see FD adding much use here.
                
> BatchlogManagerMBean
> --------------------
>
>                 Key: CASSANDRA-4635
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4635
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Jonathan Ellis
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> CASSANDRA-4542 adds an empty BatchlogManagerMBean; we should flesh it out or remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4635) BatchlogManagerMBean

Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451478#comment-13451478 ] 

Aleksey Yeschenko commented on CASSANDRA-4635:
----------------------------------------------

Right. Will get rid of coordinator as part of this task then.

As for BatchlogManagerMBean - I wanted to add a method that returns
the total count of batches in the batchlog and a method to force batch
replay. Thought these would be useful. If you think otherwise I'll
remove it.

                
> BatchlogManagerMBean
> --------------------
>
>                 Key: CASSANDRA-4635
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4635
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Jonathan Ellis
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> CASSANDRA-4542 adds an empty BatchlogManagerMBean; we should flesh it out or remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4635) BatchlogManagerMBean

Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451470#comment-13451470 ] 

Aleksey Yeschenko commented on CASSANDRA-4635:
----------------------------------------------

There is a purpose - batch replayer does FD check against it for fresh batches. That check is not critical though and can be dropped.
                
> BatchlogManagerMBean
> --------------------
>
>                 Key: CASSANDRA-4635
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4635
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Jonathan Ellis
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> CASSANDRA-4542 adds an empty BatchlogManagerMBean; we should flesh it out or remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira