[shardingsphere] branch master updated: #6872, remove unexpected error log (#7205)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 5ae2d2e  #6872, remove unexpected error log (#7205)
5ae2d2e is described below

commit 5ae2d2ecd8df6bb83998596ddf11425c96eda4b4
Author: Zhang Yonglun <zh...@apache.org>
AuthorDate: Wed Sep 2 11:35:22 2020 +0800

    #6872, remove unexpected error log (#7205)
    
    * remove unexpected error log
    
    * for comments
---
 .../java/org/apache/shardingsphere/dbtest/engine/SingleIT.java   | 4 +++-
 .../dbtest/env/authority/AuthorityEnvironmentManager.java        | 9 ++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/engine/SingleIT.java b/shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/engine/SingleIT.java
index 7f19c1f..a9a7658 100644
--- a/shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/engine/SingleIT.java
+++ b/shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/engine/SingleIT.java
@@ -19,6 +19,7 @@ package org.apache.shardingsphere.dbtest.engine;
 
 import lombok.AccessLevel;
 import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
 import org.apache.shardingsphere.dbtest.cases.assertion.root.IntegrateTestCaseAssertion;
 import org.apache.shardingsphere.dbtest.cases.assertion.root.SQLCaseType;
 import org.apache.shardingsphere.dbtest.cases.assertion.root.SQLValue;
@@ -31,6 +32,7 @@ import java.text.ParseException;
 import java.util.List;
 import java.util.stream.Collectors;
 
+@Slf4j
 @Getter(AccessLevel.PROTECTED)
 public abstract class SingleIT extends BaseIT {
     
@@ -68,6 +70,6 @@ public abstract class SingleIT extends BaseIT {
     }
     
     protected void printExceptionContext(final Exception ex) {
-        System.err.println(String.format("ruleType=%s, databaseType=%s, expectedDataFile=%s, sql=%s, ex.msg=%s", getRuleType(), getDatabaseType().getName(), expectedDataFile, sql, ex.getMessage()));
+        log.error("ruleType={}, databaseType={}, expectedDataFile={}, sql={}", getRuleType(), getDatabaseType().getName(), expectedDataFile, sql, ex);
     }
 }
diff --git a/shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/env/authority/AuthorityEnvironmentManager.java b/shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/env/authority/AuthorityEnvironmentManager.java
index 1ff10fd..402f342 100644
--- a/shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/env/authority/AuthorityEnvironmentManager.java
+++ b/shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/env/authority/AuthorityEnvironmentManager.java
@@ -17,6 +17,7 @@
 
 package org.apache.shardingsphere.dbtest.env.authority;
 
+import lombok.extern.slf4j.Slf4j;
 import org.apache.shardingsphere.infra.database.type.DatabaseType;
 
 import javax.sql.DataSource;
@@ -33,6 +34,7 @@ import java.util.Map;
 /**
  * Authority environment manager.
  */
+@Slf4j
 public final class AuthorityEnvironmentManager {
     
     private final AuthorityEnvironment authorityEnvironment;
@@ -83,12 +85,9 @@ public final class AuthorityEnvironmentManager {
         try (Connection connection = dataSource.getConnection()) {
             for (String each : sqls) {
                 try (Statement statement = connection.createStatement()) {
-                    boolean executeRet = statement.execute(each);
-                    if (!executeRet) {
-                        System.err.println("execute '" + each + "' failed");
-                    }
+                    statement.execute(each);
                 } catch (final SQLException ex) {
-                    System.err.println("execute '" + each + "' failed, ex.msg=" + ex.getMessage());
+                    log.error("execute '{}' failed.", each, ex);
                 }
             }
         }