You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Rainer Jung <ra...@kippdata.de> on 2009/09/18 00:08:19 UTC

[mod_ftp] Should ftp_connection->pbsz be an int or a long?

I compiled mod_ftp trunk on RHEL5 64 Bits. It warned about

    fc->pbsz == LONG_MAX

ftp_commands.c:1695: warning: comparison is always false due to limited
range of data type


The pbsz member is declared as being an int, but set by

    fc->pbsz = strtol(arg, &endp, 10);

and then compared against LONG_MAX. On the other hand shortly after it
is formatted to a string with %d.

I can't really see, where the pbsz is actually used. It is set by the
PBSZ command, but it seems it is not used afterwards.

Regards,

Rainer