You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/03/14 15:46:20 UTC
[kudu-CR] [tool] Fix rebuild master tool's help infomation
Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18319
Change subject: [tool] Fix rebuild master tool's help infomation
......................................................................
[tool] Fix rebuild master tool's help infomation
Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
---
M src/kudu/tools/tool_action_master.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/18319/1
--
To view, visit http://gerrit.cloudera.org:8080/18319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
[kudu-CR] [tool] Fix rebuild master tool's help infomation
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18319 )
Change subject: [tool] Fix rebuild master tool's help infomation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Mar 2022 21:11:45 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] Fix rebuild master tool's help infomation
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18319
to look at the new patch set (#2).
Change subject: [tool] Fix rebuild master tool's help infomation
......................................................................
[tool] Fix rebuild master tool's help infomation
Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
---
M src/kudu/tools/tool_action_master.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/18319/2
--
To view, visit http://gerrit.cloudera.org:8080/18319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] Fix rebuild master tool's help infomation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18319 )
Change subject: [tool] Fix rebuild master tool's help infomation
......................................................................
[tool] Fix rebuild master tool's help infomation
Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Reviewed-on: http://gerrit.cloudera.org:8080/18319
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tools/tool_action_master.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [tool] Fix rebuild master tool's help infomation
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18319 )
Change subject: [tool] Fix rebuild master tool's help infomation
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18319/1/src/kudu/tools/tool_action_master.cc
File src/kudu/tools/tool_action_master.cc:
http://gerrit.cloudera.org:8080/#/c/18319/1/src/kudu/tools/tool_action_master.cc@117
PS1, Line 117: " of
> nit: missing space
Done
--
To view, visit http://gerrit.cloudera.org:8080/18319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 09:51:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tool] Fix rebuild master tool's help infomation
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18319 )
Change subject: [tool] Fix rebuild master tool's help infomation
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 15:22:42 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] Fix rebuild master tool's help infomation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18319 )
Change subject: [tool] Fix rebuild master tool's help infomation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Mar 2022 21:20:42 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] Fix rebuild master tool's help infomation
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18319 )
Change subject: [tool] Fix rebuild master tool's help infomation
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18319/1/src/kudu/tools/tool_action_master.cc
File src/kudu/tools/tool_action_master.cc:
http://gerrit.cloudera.org:8080/#/c/18319/1/src/kudu/tools/tool_action_master.cc@117
PS1, Line 117: "of
nit: missing space
--
To view, visit http://gerrit.cloudera.org:8080/18319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I301df64f0c1a42a00f19bced18f13aa5057b068c
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Mar 2022 22:34:36 +0000
Gerrit-HasComments: Yes