You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/08 09:57:08 UTC

[GitHub] [hudi] danny0405 commented on pull request #5436: [RFC-51] [HUDI-3478] Change Data Capture RFC

danny0405 commented on PR #5436:
URL: https://github.com/apache/hudi/pull/5436#issuecomment-1149711512

   > > only when the HoodieMergeHandle is called, not always. And other scenarios can re-use the existing files.
   > 
   > For HoodieCreateHandle, we deduce `op` on the fly since the beforeImage will be null for inserts? I think we are close enough here to begin implementation. Is the next step to get a more detailed design updated here in RFC? as @danny0405 mentioned?
   
   It seems we make consensus that for COW table:
   
       1. for create handle, we deduce the _op directly from the record because they are all INSERTs
       2. for merge handle, we can deduce the before image on the fly when reading by comparing two 
           different versions of file slice and there is no need to write another cdc block.
   
   Fine with that.
   
   But what about MOR table, the strategy is not clear for me still.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org