You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/06/13 16:14:04 UTC

Review Request 35427: Installed Version Getting out of sync

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35427/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-11901
    https://issues.apache.org/jira/browse/AMBARI-11901


Repository: ambari


Description
-------

1) Installed HDP 2.3.0.0-X cluster, running fine
2) Register and install a new version HDP 2.3.0.0-Y on all hosts, that all looks good
3) Went to kerberos wizard, chose manual option and proceeded to Confirm Configuration (which has the ability to download csv).
4) At that point, I dismissed the wizard. So effectively, i have really made no changes to the cluster.
5) Now I go to Admin > stacks & Versions and HDP 2.3.0.0-Y is out of sync on all hosts.

Actually, the Kerberos Wizard does add a service to the database, and Ambari always changes the version to OUT_OF_SYNC when a component is added. If this is the case, we just need to exclude components like Kerberos, Ambari Metrics, SQL, etc., which already have the "versionAdvertised" element in the metainfo.xml file.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java 1acb54b 
  ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 078d4c7 

Diff: https://reviews.apache.org/r/35427/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [2.764s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.444s]
[INFO] Ambari Server ..................................... SUCCESS [48:44.178s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48:48.919s
[INFO] Finished at: Sat Jun 13 16:20:12 EEST 2015
[INFO] Final Memory: 36M/290M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 35427: Installed Version Getting out of sync

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On June 15, 2015, 12:20 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java, line 161
> > <https://reviews.apache.org/r/35427/diff/1/?file=984387#file984387line161>
> >
> >     sence -> sense

thanks!


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35427/#review87881
-----------------------------------------------------------


On June 13, 2015, 2:14 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35427/
> -----------------------------------------------------------
> 
> (Updated June 13, 2015, 2:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11901
>     https://issues.apache.org/jira/browse/AMBARI-11901
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) Installed HDP 2.3.0.0-X cluster, running fine
> 2) Register and install a new version HDP 2.3.0.0-Y on all hosts, that all looks good
> 3) Went to kerberos wizard, chose manual option and proceeded to Confirm Configuration (which has the ability to download csv).
> 4) At that point, I dismissed the wizard. So effectively, i have really made no changes to the cluster.
> 5) Now I go to Admin > stacks & Versions and HDP 2.3.0.0-Y is out of sync on all hosts.
> 
> Actually, the Kerberos Wizard does add a service to the database, and Ambari always changes the version to OUT_OF_SYNC when a component is added. If this is the case, we just need to exclude components like Kerberos, Ambari Metrics, SQL, etc., which already have the "versionAdvertised" element in the metainfo.xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java 1acb54b 
>   ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 078d4c7 
> 
> Diff: https://reviews.apache.org/r/35427/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [2.764s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.444s]
> [INFO] Ambari Server ..................................... SUCCESS [48:44.178s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48:48.919s
> [INFO] Finished at: Sat Jun 13 16:20:12 EEST 2015
> [INFO] Final Memory: 36M/290M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 35427: Installed Version Getting out of sync

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35427/#review87881
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
<https://reviews.apache.org/r/35427/#comment140294>

    sence -> sense



ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
<https://reviews.apache.org/r/35427/#comment140295>

    sence -> sense


- Jonathan Hurley


On June 13, 2015, 10:14 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35427/
> -----------------------------------------------------------
> 
> (Updated June 13, 2015, 10:14 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11901
>     https://issues.apache.org/jira/browse/AMBARI-11901
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) Installed HDP 2.3.0.0-X cluster, running fine
> 2) Register and install a new version HDP 2.3.0.0-Y on all hosts, that all looks good
> 3) Went to kerberos wizard, chose manual option and proceeded to Confirm Configuration (which has the ability to download csv).
> 4) At that point, I dismissed the wizard. So effectively, i have really made no changes to the cluster.
> 5) Now I go to Admin > stacks & Versions and HDP 2.3.0.0-Y is out of sync on all hosts.
> 
> Actually, the Kerberos Wizard does add a service to the database, and Ambari always changes the version to OUT_OF_SYNC when a component is added. If this is the case, we just need to exclude components like Kerberos, Ambari Metrics, SQL, etc., which already have the "versionAdvertised" element in the metainfo.xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java 1acb54b 
>   ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 078d4c7 
> 
> Diff: https://reviews.apache.org/r/35427/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [2.764s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.444s]
> [INFO] Ambari Server ..................................... SUCCESS [48:44.178s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48:48.919s
> [INFO] Finished at: Sat Jun 13 16:20:12 EEST 2015
> [INFO] Final Memory: 36M/290M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 35427: Installed Version Getting out of sync

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35427/#review87870
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On June 13, 2015, 10:14 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35427/
> -----------------------------------------------------------
> 
> (Updated June 13, 2015, 10:14 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11901
>     https://issues.apache.org/jira/browse/AMBARI-11901
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) Installed HDP 2.3.0.0-X cluster, running fine
> 2) Register and install a new version HDP 2.3.0.0-Y on all hosts, that all looks good
> 3) Went to kerberos wizard, chose manual option and proceeded to Confirm Configuration (which has the ability to download csv).
> 4) At that point, I dismissed the wizard. So effectively, i have really made no changes to the cluster.
> 5) Now I go to Admin > stacks & Versions and HDP 2.3.0.0-Y is out of sync on all hosts.
> 
> Actually, the Kerberos Wizard does add a service to the database, and Ambari always changes the version to OUT_OF_SYNC when a component is added. If this is the case, we just need to exclude components like Kerberos, Ambari Metrics, SQL, etc., which already have the "versionAdvertised" element in the metainfo.xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java 1acb54b 
>   ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 078d4c7 
> 
> Diff: https://reviews.apache.org/r/35427/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [2.764s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.444s]
> [INFO] Ambari Server ..................................... SUCCESS [48:44.178s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48:48.919s
> [INFO] Finished at: Sat Jun 13 16:20:12 EEST 2015
> [INFO] Final Memory: 36M/290M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>